linux-kernel - Re: [PATCH] pinctrl: stm32: fix hwspinlock resource leak in probe function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdanWwXSAu4oH9LnnTJ0mxB+7sorUKj_juFrRebhdL1WKQ@mail.gmail.com>
Date: Wed, 29 Oct 2025 23:38:01 +0100
From: Linus Walleij <linus.walleij@...aro.org>
To: Haotian Zhang <vulab@...as.ac.cn>
Cc: antonio.borneo@...s.st.com, mcoquelin.stm32@...il.com, 
	alexandre.torgue@...s.st.com, linux-gpio@...r.kernel.org, 
	linux-stm32@...md-mailman.stormreply.com, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pinctrl: stm32: fix hwspinlock resource leak in probe function

On Wed, Oct 29, 2025 at 2:43 AM Haotian Zhang <vulab@...as.ac.cn> wrote:

> In stm32_pctl_probe(), hwspin_lock_request_specific() is called to
> request a hwspinlock, but the acquired lock is not freed on multiple
> error paths after this call. This causes resource leakage when the
> function fails to initialize properly.
>
> Use devm_hwspin_lock_request_specific() instead of
> hwspin_lock_request_specific() to automatically manage the hwspinlock
> resource lifecycle.
>
> Fixes: 97cfb6cd34f2 ("pinctrl: stm32: protect configuration registers with a hwspinlock")
> Signed-off-by: Haotian Zhang <vulab@...as.ac.cn>

Patch applied!

Yours,
Linus Walleij