linux-kernel - Re: [PATCH v12 12/23] KVM: selftests: Add helper to initialize TDX VM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c08af988-45c7-4b8d-a4b4-ffb20736e2be@intel.com>
Date: Wed, 29 Oct 2025 16:01:46 -0700
From: Reinette Chatre <reinette.chatre@...el.com>
To: Ira Weiny <ira.weiny@...el.com>, Sagi Shahar <sagis@...gle.com>,
	<linux-kselftest@...r.kernel.org>, Paolo Bonzini <pbonzini@...hat.com>,
	"Shuah Khan" <shuah@...nel.org>, Sean Christopherson <seanjc@...gle.com>,
	"Ackerley Tng" <ackerleytng@...gle.com>, Ryan Afranji <afranji@...gle.com>,
	Andrew Jones <ajones@...tanamicro.com>, Isaku Yamahata
	<isaku.yamahata@...el.com>, "Erdem Aktas" <erdemaktas@...gle.com>, Rick
 Edgecombe <rick.p.edgecombe@...el.com>, Roger Wang <runanwang@...gle.com>,
	Binbin Wu <binbin.wu@...ux.intel.com>, Oliver Upton <oliver.upton@...ux.dev>,
	"Pratik R. Sampat" <pratikrajesh.sampat@....com>, Chao Gao
	<chao.gao@...el.com>, Chenyi Qiang <chenyi.qiang@...el.com>
CC: <linux-kernel@...r.kernel.org>, <kvm@...r.kernel.org>
Subject: Re: [PATCH v12 12/23] KVM: selftests: Add helper to initialize TDX VM



On 10/29/25 2:16 PM, Ira Weiny wrote:
> 
>> +
>> +#define vm_tdx_vm_ioctl(vm, cmd, flags, arg)				\
>> +({									\
>> +	int ret = __vm_tdx_vm_ioctl(vm, cmd, flags, arg);		\
>> +									\
>> +	__TEST_ASSERT_VM_VCPU_IOCTL(!ret, #cmd,	ret, vm);		\
>> +})
>> +
>> +#define __vm_tdx_vcpu_ioctl(vcpu, cmd, metadata, arg)			\
> 
> NIT: Why not just call 'metadata', 'flags'?
> 

Making this change would make the code easier to read by being consistent
with caller here as well as with kernel terms. If making this change please
consider its callers also, for example the "metadata" local variable of
tdx_init_mem_region() introduced in patch #14. Naming it flags would then also
be consistent with this change as well as how the flag is used in the kernel.

Reinette