linux-kernel - Re: [PATCH] nvme: drop bogus nid quirk for multipath devices which passed id test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251029074403.GA30412@lst.de>
Date: Wed, 29 Oct 2025 08:44:03 +0100
From: Christoph Hellwig <hch@....de>
To: Daniel Wagner <wagi@...nel.org>
Cc: Keith Busch <kbusch@...nel.org>, Christoph Hellwig <hch@....de>,
	John Meneghini <jmeneghi@...hat.com>,
	Bryan Gurney <bgurney@...hat.com>, linux-nvme@...ts.infradead.org,
	linux-kernel@...r.kernel.org, Daniel Wagner <dwagner@...e.de>
Subject: Re: [PATCH] nvme: drop bogus nid quirk for multipath devices which
 passed id test

On Tue, Oct 28, 2025 at 01:54:56PM +0100, Daniel Wagner wrote:
> Obviously, using the correct IDs is really hard. There are at least two devices
> which share a the device id and one needs the bogus id workaround the other
> doesn't.
> 
> We discussed the idea to pass through configuration from the kernel command line
> at ALPSS. I am not sure, how far we got with this yet. What about something like
> this here?

The Intel devices are dual ported and multipath cabable, too.  Which
isn't surprising at the dell one is just an OEM version of them.

But more imporantly dropping the quirk for multipath devices is
fundamentally the wrong thing to do, as we really need proper IDs for
multipathing.  So just add another entry for the Dell device using
the dell subvendor/subdevice id that does not have the quirk.