linux-kernel - Re: [PATCH] drm/panel: kingdisplay-kd097d04: Disable EoTp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5465f445fe9e230f1f37cbb22a97ff2b7c9c3d2e.camel@googlemail.com>
Date: Wed, 29 Oct 2025 09:15:09 +0100
From: Christoph Fritz <chf.fritz@...glemail.com>
To: Sebastian Fleer <dev@...rp.de>
Cc: Neil Armstrong <neil.armstrong@...aro.org>, Jessica Zhang	
 <jesszhan0024@...il.com>, Maarten Lankhorst
 <maarten.lankhorst@...ux.intel.com>,  Maxime Ripard <mripard@...nel.org>,
 Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>, 
 Simona Vetter <simona@...ll.ch>, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/panel: kingdisplay-kd097d04: Disable EoTp

>  >> Fixes: d97e71e44937 ("drm/bridge: synopsys: dw-mipi-dsi: enable EoTp 
> by default")

Nitpick: Your Mailclient messed up quoting.

>  >
>  > Just to clarify: This is not a fix for that commit, it is a fix for the
>  > panel driver itself.
>  >
>  > EoTp is the default in Linux, a panel driver cannot enable it, only
>  > disable it.
>  >
>  > Commit d97e71e44937 ("drm/bridge: synopsys: dw-mipi-dsi: enable EoTp by
>  > default") fixed a bug in the synopsys dw-mipi-dsi because EoTp was not
>  > enabled there by default.
>  >
>  > Enabling EoTp in dw-mipi-dsi revealed an underlying issue in panel-
>  > kingdisplay-kd097d04.
>  >
>  > That same issue appears if one would connect this panel to a different
>  > mipi-dsi core (because there EoTp is also enabled by default).
>  >
> thanks for your clarification. You're right, this change is merely a 
> workaround for the kingdisplay panel.

It's not a workaround, it's the actual fix.

> However, I'm in favor of keeping the "Fixes:" line since using bisect, 
> commit d97e71e44937 ("drm/bridge: synopsys: dw-mipi-dsi: enable EoTp by
> default") is found as the first commit that shows distorted output for 
> that panel.

Documentation states:

 || A Fixes: tag indicates that the patch fixes a bug in a previous
 || commit

You are quoting the wrong commit in your Fixes: tag.