linux-kernel - Re: [PATCH 2/2] arm64: dts: qcom: sm8150: Add support for Xiaomi Redmi K20 Pro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d99b03f4-ae44-4b7d-b4d0-45e2c3058db0@oss.qualcomm.com>
Date: Wed, 29 Oct 2025 10:06:50 +0100
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Piyush Raj Chouhan <pc1598@...nlining.org>, linux-arm-msm@...r.kernel.org
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-hardening@...r.kernel.org, andersson@...nel.org,
        konradybcio@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
        conor+dt@...nel.org, tony.luck@...el.com, gpiccoli@...lia.com
Subject: Re: [PATCH 2/2] arm64: dts: qcom: sm8150: Add support for Xiaomi
 Redmi K20 Pro

On 10/28/25 5:13 PM, Piyush Raj Chouhan wrote:
> Hi, konrad 
> 
> 
>>> +
>>> +&i2c19 {
>>> +	/* goodix,gt9886 @5d  */
>>
>> I see there's driver support for the GT98*97* - is there a chance you can
>> reuse some of it?
>>
> 
> I am currently testing touch on gtx8 driver which currently is in lkml, once its merged we could add support for it.
> 
> https://lore.kernel.org/linux-input/20250918-gtx8-v1-0-cba879c84775@mainlining.org

That's great!

[...]

>>> +	led@2 {
>>> +		reg = <2>;
>>> +		color = <LED_COLOR_ID_RED>;
>>> +		function = LED_FUNCTION_STATUS;
>>> +		function-enumerator = <0>;
>>> +	};
>>> +
>>> +	led@3 {
>>> +		reg = <3>;
>>> +		color = <LED_COLOR_ID_RED>;
>>> +		function = LED_FUNCTION_STATUS;
>>> +		function-enumerator = <1>;
>>> +	};
>>
>> Are there really two separate red LEDs?
> 
> Yes, it has popup camera with an LED on both side, i have verified functionality of both LEDs. 

OK, would you mind adding a label= entry with perhaps "Pop-up camera
front/back"?

Konrad