linux-kernel - Re: [PATCH] soc: qcom: smem: fix hwspinlock resource leak in probe error paths

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f062bc4f-828a-4a91-9257-1b1164f6df28@oss.qualcomm.com>
Date: Wed, 29 Oct 2025 10:14:05 +0100
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Haotian Zhang <vulab@...as.ac.cn>, andersson@...nel.org,
        konradybcio@...nel.org
Cc: linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] soc: qcom: smem: fix hwspinlock resource leak in probe
 error paths

On 10/29/25 3:27 AM, Haotian Zhang wrote:
> The hwspinlock acquired via hwspin_lock_request_specific() is not
> released on several error paths. This results in resource leakage
> when probe fails.
> 
> Switch to devm_hwspin_lock_request_specific() to automatically
> handle cleanup on probe failure. Remove the manual hwspin_lock_free()
> in qcom_smem_remove() as devm handles it automatically.
> 
> Fixes: 20bb6c9de1b7 ("soc: qcom: smem: map only partitions used by local HOST")
> Signed-off-by: Haotian Zhang <vulab@...as.ac.cn>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>

Konrad