linux-kernel - Re: drivers/phy/ti/phy-omap-usb2.c:442:4-11: WARNING: Consider using %pe to print PTR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aQHi4nUfIlcN1ac6@hovoldconsulting.com>
Date: Wed, 29 Oct 2025 10:48:18 +0100
From: Johan Hovold <johan@...nel.org>
To: Julia Lawall <julia.lawall@...ia.fr>
Cc: Vinod Koul <vkoul@...nel.org>,
	Neil Armstrong <neil.armstrong@...aro.org>,
	linux-kernel@...r.kernel.org, oe-kbuild-all@...ts.linux.de,
	cocci@...ia.fr, Jakub Kicinski <kuba@...nel.org>,
	Tariq Toukan <tariqt@...dia.com>
Subject: Re: drivers/phy/ti/phy-omap-usb2.c:442:4-11: WARNING: Consider using
 %pe to print PTR_ERR() (fwd)

On Tue, Oct 28, 2025 at 05:02:40PM +0100, Julia Lawall wrote:

> ---------- Forwarded message ----------
> Date: Tue, 28 Oct 2025 22:32:58 +0800
> From: kernel test robot <lkp@...el.com>
> To: oe-kbuild@...ts.linux.dev
> Cc: lkp@...el.com, Julia Lawall <julia.lawall@...ia.fr>
> Subject: drivers/phy/ti/phy-omap-usb2.c:442:4-11: WARNING: Consider using %pe to
>      print PTR_ERR()
> 
> BCC: lkp@...el.com
> CC: oe-kbuild-all@...ts.linux.dev
> CC: linux-kernel@...r.kernel.org
> TO: Johan Hovold <johan@...nel.org>
> CC: Vinod Koul <vkoul@...nel.org>
> CC: Neil Armstrong <neil.armstrong@...aro.org>
> 
> Hi Johan,
> 
> First bad commit (maybe != root cause):
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   fd57572253bc356330dbe5b233c2e1d8426c66fd
> commit: 8209b3f79703b8ff09f84a79c46ead0df7260d9f phy: ti: omap-usb2: enable compile testing
> date:   3 months ago
> :::::: branch date: 21 hours ago
> :::::: commit date: 3 months ago
> config: sparc64-randconfig-r064-20251028 (https://download.01.org/0day-ci/archive/20251028/202510282255.6lFijMzE-lkp@intel.com/config)
> compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Reported-by: Julia Lawall <julia.lawall@...ia.fr>
> | Closes: https://lore.kernel.org/r/202510282255.6lFijMzE-lkp@intel.com/
> 
> cocci warnings: (new ones prefixed by >>)
> >> drivers/phy/ti/phy-omap-usb2.c:442:4-11: WARNING: Consider using %pe to print PTR_ERR()

Why is this framed as a warning? It's at best a suggestion for a style
change that not everyone agrees with (me included). A driver may want to
use numeric errnos for consistency, and there certainly nothing
"redundant" in calling PTR_ERR() as the cocci script claims.

	https://lore.kernel.org/all/1758192227-701925-2-git-send-email-tariqt@nvidia.com/

Please consider dropping this from the tree or at least from what the
build bots run to avoid the unnecessary noise and churn this causes.

Johan