linux-kernel - Re: [PATCH v1 1/2] tools/rtla: Add for_each_monitored

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP4=nvQbr5Adrk6_TDLge0TfqOwOhE9Q4iRzCqQKpwx29d_QHA@mail.gmail.com>
Date: Wed, 29 Oct 2025 11:29:45 +0100
From: Tomas Glozar <tglozar@...hat.com>
To: Costa Shulyupin <costa.shul@...hat.com>
Cc: Steven Rostedt <rostedt@...dmis.org>, Crystal Wood <crwood@...hat.com>, 
	John Kacur <jkacur@...hat.com>, Eder Zulian <ezulian@...hat.com>, 
	linux-trace-kernel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/2] tools/rtla: Add for_each_monitored_cpu() helper

čt 2. 10. 2025 v 14:36 odesílatel Costa Shulyupin
<costa.shul@...hat.com> napsal:
>
> The rtla tools have many instances of iterating over CPUs while
> checking if they are monitored.
>
> Add a for_each_monitored_cpu() helper macro to make the code
> more readable and reduce code duplication.
>

Yeah this iteration is repeated many times.

> Signed-off-by: Costa Shulyupin <costa.shul@...hat.com>
> ---
>  tools/tracing/rtla/src/common.h        |  4 ++++
>  tools/tracing/rtla/src/osnoise_hist.c  | 28 ++++++----------------
>  tools/tracing/rtla/src/osnoise_top.c   |  4 +---
>  tools/tracing/rtla/src/timerlat.c      |  9 ++------
>  tools/tracing/rtla/src/timerlat_hist.c | 32 +++++++-------------------
>  tools/tracing/rtla/src/timerlat_top.c  |  4 +---
>  6 files changed, 23 insertions(+), 58 deletions(-)
>

Reviewed-by: Tomas Glozar <tglozar@...hat.com>

Tomas