linux-kernel - Re: [PATCH v2 2/4] ASoC: cs4271: Disable regulators in component

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ab9c1f88026058fde8cc37057864f25889ce47d1.camel@gmail.com>
Date: Wed, 29 Oct 2025 12:14:00 +0100
From: Alexander Sverdlin <alexander.sverdlin@...il.com>
To: Herve Codina <herve.codina@...tlin.com>
Cc: linux-sound@...r.kernel.org, patches@...nsource.cirrus.com, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, Thomas Petazzoni	
 <thomas.petazzoni@...tlin.com>, stable@...r.kernel.org, David Rhodes	
 <david.rhodes@...rus.com>, Richard Fitzgerald <rf@...nsource.cirrus.com>, 
 Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, Rob
 Herring <robh@...nel.org>,  Krzysztof Kozlowski	 <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Jaroslav Kysela	 <perex@...ex.cz>,
 Takashi Iwai <tiwai@...e.com>, Nikita Shubin	 <nikita.shubin@...uefel.me>,
 Axel Lin <axel.lin@...ics.com>, Brian Austin	 <brian.austin@...rus.com>
Subject: Re: [PATCH v2 2/4] ASoC: cs4271: Disable regulators in
 component_probe() error path

Hi!

On Wed, 2025-10-29 at 10:39 +0100, Herve Codina wrote:
> The commit 9a397f473657 ("ASoC: cs4271: add regulator consumer support")
> has introduced regulators in the driver.
> 
> Regulators are enabled at the beginning of component_probe() but they
> are not disabled on errors. This can lead to unbalanced enable/disable.
> 
> Fix the error path to disable regulators on errors.
> 
> Fixes: 9a397f473657 ("ASoC: cs4271: add regulator consumer support")
> Cc: stable@...r.kernel.org
> Signed-off-by: Herve Codina <herve.codina@...tlin.com>

Reviewed-by: Alexander Sverdlin <alexander.sverdlin@...il.com>

-- 
Alexander Sverdlin.