linux-kernel - Re: [PATCH v2 2/6] panic: sys_info: Align constant definition names with parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aQLGhzh9UOYNM-V7@U-2FWC9VHC-2323.local>
Date: Thu, 30 Oct 2025 09:59:35 +0800
From: Feng Tang <feng.tang@...ux.alibaba.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: linux-kernel@...r.kernel.org, Andrew Morton <akpm@...ux-foundation.org>,
	Petr Mladek <pmladek@...e.com>
Subject: Re: [PATCH v2 2/6] panic: sys_info: Align constant definition names
 with parameters

On Wed, Oct 29, 2025 at 12:07:37PM +0100, Andy Shevchenko wrote:
> Align constant definition names with parameters to make it easier
> to map. It's also better to maintain and extend the names while
> keeping their uniqueness.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Reviewed-by: Feng Tang <feng.tang@...ux.alibaba.com>

Thanks,
Feng

>
> ---
>  include/linux/sys_info.h | 2 +-
>  kernel/panic.c           | 2 +-
>  lib/sys_info.c           | 4 ++--
>  3 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/include/linux/sys_info.h b/include/linux/sys_info.h
> index 89d77dc4f2ed..a5bc3ea3d44b 100644
> --- a/include/linux/sys_info.h
> +++ b/include/linux/sys_info.h
> @@ -14,7 +14,7 @@
>  #define SYS_INFO_LOCKS			0x00000008
>  #define SYS_INFO_FTRACE			0x00000010
>  #define SYS_INFO_PANIC_CONSOLE_REPLAY	0x00000020
> -#define SYS_INFO_ALL_CPU_BT		0x00000040
> +#define SYS_INFO_ALL_BT			0x00000040
>  #define SYS_INFO_BLOCKED_TASKS		0x00000080
>  
>  void sys_info(unsigned long si_mask);
> diff --git a/kernel/panic.c b/kernel/panic.c
> index 341c66948dcb..0d52210a9e2b 100644
> --- a/kernel/panic.c
> +++ b/kernel/panic.c
> @@ -401,7 +401,7 @@ static void panic_trigger_all_cpu_backtrace(void)
>   */
>  static void panic_other_cpus_shutdown(bool crash_kexec)
>  {
> -	if (panic_print & SYS_INFO_ALL_CPU_BT)
> +	if (panic_print & SYS_INFO_ALL_BT)
>  		panic_trigger_all_cpu_backtrace();
>  
>  	/*
> diff --git a/lib/sys_info.c b/lib/sys_info.c
> index d542a024406a..6b0188b30227 100644
> --- a/lib/sys_info.c
> +++ b/lib/sys_info.c
> @@ -23,7 +23,7 @@ static const struct sys_info_name  si_names[] = {
>  	{ SYS_INFO_TIMERS,		"timers" },
>  	{ SYS_INFO_LOCKS,		"locks" },
>  	{ SYS_INFO_FTRACE,		"ftrace" },
> -	{ SYS_INFO_ALL_CPU_BT,		"all_bt" },
> +	{ SYS_INFO_ALL_BT,		"all_bt" },
>  	{ SYS_INFO_BLOCKED_TASKS,	"blocked_tasks" },
>  };
>  
> @@ -118,7 +118,7 @@ void sys_info(unsigned long si_mask)
>  	if (si_mask & SYS_INFO_FTRACE)
>  		ftrace_dump(DUMP_ALL);
>  
> -	if (si_mask & SYS_INFO_ALL_CPU_BT)
> +	if (si_mask & SYS_INFO_ALL_BT)
>  		trigger_all_cpu_backtrace();
>  
>  	if (si_mask & SYS_INFO_BLOCKED_TASKS)
> -- 
> 2.50.1