linux-kernel - Re: [PATCH 2/2] drm/imx: parallel-display: add the bridge before attaching it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <df18fc81-3ef6-4423-af7a-3472a731c4ad@bootlin.com>
Date: Thu, 30 Oct 2025 15:20:46 +0100
From: Louis Chauvet <louis.chauvet@...tlin.com>
To: Luca Ceresoli <luca.ceresoli@...tlin.com>,
 Ernest Van Hoecke <ernestvanhoecke@...il.com>,
 Philipp Zabel <p.zabel@...gutronix.de>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>
Cc: Hui Pu <Hui.Pu@...ealthcare.com>,
 Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
 dri-devel@...ts.freedesktop.org, imx@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] drm/imx: parallel-display: add the bridge before
 attaching it



Le 14/10/2025 à 13:30, Luca Ceresoli a écrit :
> Invoking drm_bridge_add() is good practice, so add it to this driver.
> 
> Link: https://lore.kernel.org/all/DDHZ5GO9MPF0.CGYTVBI74FOZ@bootlin.com
> Signed-off-by: Luca Ceresoli <luca.ceresoli@...tlin.com>

Reviewed-by: Louis Chauvet <louis.chauvet@...tlin.com>

> ---
> 
> Note: there is a proposal to make drm_bridge_add() mandatory before
> drm_bridge_attach():
> https://lore.kernel.org/lkml/20251003-b4-drm-bridge-alloc-add-before-attach-v1-3-92fb40d27704@bootlin.com/
> ---
>   drivers/gpu/drm/imx/ipuv3/parallel-display.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/imx/ipuv3/parallel-display.c b/drivers/gpu/drm/imx/ipuv3/parallel-display.c
> index 3d0de9c6e925978b7532b6d13caf6909cc343dd7..7fc6af7033078eef6be0672ff0d1c7bddda88ba1 100644
> --- a/drivers/gpu/drm/imx/ipuv3/parallel-display.c
> +++ b/drivers/gpu/drm/imx/ipuv3/parallel-display.c
> @@ -256,6 +256,8 @@ static int imx_pd_probe(struct platform_device *pdev)
>   
>   	platform_set_drvdata(pdev, imxpd);
>   
> +	devm_drm_bridge_add(dev, &imxpd->bridge);
> +
>   	return component_add(dev, &imx_pd_ops);
>   }
>   
> 

-- 
--
Louis Chauvet, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com