linux-kernel - Re: [PATCH] arm64: acpi: Fix incorrect check for default console message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aQN0YWUYaPYWpgJM@willie-the-truck>
Date: Thu, 30 Oct 2025 14:21:21 +0000
From: Will Deacon <will@...nel.org>
To: Punit Agrawal <punit.agrawal@....qualcomm.com>
Cc: catalin.marinas@....com, guohanjun@...wei.com, chenl311@...natelecom.cn,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: acpi: Fix incorrect check for default console
 message

On Mon, Oct 27, 2025 at 02:19:41PM +0000, Punit Agrawal wrote:
> bad3fa2fb920 ("ACPI: Suppress misleading SPCR console message when
> SPCR table is absent") mistakenly assumes acpi_parse_spcr() returning
> 0 to indicate a failure to parse SPCR and prints a message to the
> kernel logs accordingly. In reality acpi_parse_spcr() returns 0 on
> success and -ERRNO on failure.
> 
> Fix the faulty check to output the correct logging message.
> 
> Fixes: bad3fa2fb920 ("ACPI: Suppress misleading SPCR console message when SPCR table is absent")
> Signed-off-by: Punit Agrawal <punit.agrawal@....qualcomm.com>
> ---
> Hi,
> 
> After sending a patch to fix incorrect parsing of SPCR[0], I was still
> seeing inconsistent logging on arm64. The result is this nugget.
> 
> Considering the pointless churn - I wondered if it isn't better to
> drop the message? If others agree, I can send a patch (and revert
> bad3fa2fb920 while at it).

I'd be happy dropping the message as it looks pretty useless to me,
especially given that the current logic is broken.

Will