[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20251030143051.GJaQN2m2fniYVRtBxn@fat_crate.local>
Date: Thu, 30 Oct 2025 15:30:51 +0100
From: Borislav Petkov <bp@...en8.de>
To: niravkumarlaxmidas.rabara@...era.com
Cc: dinguyen@...nel.org, matthew.gerlach@...era.com, robh@...nel.org,
	krzk+dt@...nel.org, conor+dt@...nel.org, tony.luck@...el.com,
	linux-edac@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/6] EDAC/altera: Add IO96B ECC support for Agilex5
 SoCFPGA
On Tue, Oct 28, 2025 at 05:22:30PM +0800, niravkumarlaxmidas.rabara@...era.com wrote:
> diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig
> index 39352b9b7a7e..33a9fccde2fe 100644
> --- a/drivers/edac/Kconfig
> +++ b/drivers/edac/Kconfig
> @@ -410,6 +410,16 @@ config EDAC_ALTERA_SDRAM
>  	  preloader must initialize the SDRAM before loading
>  	  the kernel.
>  
> +config EDAC_ALTERA_IO96B
> +	bool "Altera I096B ECC"
Is this and the other new Kconfig symbols you're adding absolutely needed?
IOW, why can't the driver simply load on that new hw without needing Kconfig
symbols at all?
What are they really saving?
Thx.
-- 
Regards/Gruss,
    Boris.
https://people.kernel.org/tglx/notes-about-netiquette
Powered by blists - more mailing lists
 
