linux-kernel - Re: [PATCH] rust_binder: use compat_ptr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025103009-sixfold-peculiar-496c@gregkh>
Date: Thu, 30 Oct 2025 16:06:14 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Alice Ryhl <aliceryhl@...gle.com>
Cc: Carlos Llamas <cmllamas@...gle.com>,
	Arve Hjønnevåg <arve@...roid.com>,
	Todd Kjos <tkjos@...roid.com>, Martijn Coenen <maco@...roid.com>,
	Joel Fernandes <joelagnelf@...dia.com>,
	Christian Brauner <brauner@...nel.org>,
	Suren Baghdasaryan <surenb@...gle.com>,
	linux-kernel@...r.kernel.org, rust-for-linux@...r.kernel.org
Subject: Re: [PATCH] rust_binder: use compat_ptr_ioctl

On Thu, Oct 30, 2025 at 01:25:19PM +0000, Alice Ryhl wrote:
> On Thu, Oct 30, 2025 at 01:38:56PM +0100, Greg Kroah-Hartman wrote:
> > On Thu, Oct 30, 2025 at 10:41:04AM +0000, Alice Ryhl wrote:
> > > This is commit 1832f2d8ff69 ("compat_ioctl: move more drivers to
> > > compat_ptr_ioctl") but for Rust Binder.
> > 
> > You might want to spell out why this is happening, not just refer to
> > another commit to try to find that information to make it more clear
> > here as to how to attempt to review this :)
> 
> I can replace the commit message with:
> 
> Binder always treats the ioctl argument as a pointer. In this scenario,
> the idiomatic way to implement compat_ioctl is to use compat_ptr_ioctl.
> Thus update Rust Binder to do that.

Sounds good to me!