linux-kernel - Re: [PATCH v2 3/4] clocksource/drivers/arm_arch_timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <86pla4uy5c.wl-maz@kernel.org>
Date: Thu, 30 Oct 2025 16:55:59 +0000
From: Marc Zyngier <maz@...nel.org>
To: Lorenzo Pieralisi <lpieralisi@...nel.org>
Cc: linux-kernel@...r.kernel.org,
	linux-acpi@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	Hanjun Guo <guohanjun@...wei.com>,
	Sudeep Holla <sudeep.holla@....com>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Daniel Lezcano <daniel.lezcano@...aro.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Mark Rutland <mark.rutland@....com>,
	Alexandru Elisei <alexandru.elisei@....com>,
	Steven Price <steven.price@....com>
Subject: Re: [PATCH v2 3/4] clocksource/drivers/arm_arch_timer_mmio: Switch over to standalone driver

On Thu, 30 Oct 2025 16:35:11 +0000,
Lorenzo Pieralisi <lpieralisi@...nel.org> wrote:
> 
> On Thu, Aug 14, 2025 at 04:46:21PM +0100, Marc Zyngier wrote:
> 
> [...]
> 
> > diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c
> 
> [...]
> 
> >  #ifdef CONFIG_ACPI_GTDT
> > -static int __init
> > -arch_timer_mem_verify_cntfrq(struct arch_timer_mem *timer_mem)
> > -{
> > -	struct arch_timer_mem_frame *frame;
> > -	u32 rate;
> > -	int i;
> > -
> > -	for (i = 0; i < ARCH_TIMER_MEM_MAX_FRAMES; i++) {
> > -		frame = &timer_mem->frame[i];
> > -
> > -		if (!frame->valid)
> > -			continue;
> > -
> > -		rate = arch_timer_mem_frame_get_cntfrq(frame);
> > -		if (rate == arch_timer_rate)
> > -			continue;
> > -
> > -		pr_err(FW_BUG "CNTFRQ mismatch: frame @ %pa: (0x%08lx), CPU: (0x%08lx)\n",
> > -			&frame->cntbase,
> > -			(unsigned long)rate, (unsigned long)arch_timer_rate);
> > -
> > -		return -EINVAL;
> > -	}
> > -
> > -	return 0;
> > -}
> > -
> > -static int __init arch_timer_mem_acpi_init(int platform_timer_count)
> > -{
> > -	struct arch_timer_mem *timers, *timer;
> > -	struct arch_timer_mem_frame *frame, *best_frame = NULL;
> > -	int timer_count, i, ret = 0;
> > -
> > -	timers = kcalloc(platform_timer_count, sizeof(*timers),
> > -			    GFP_KERNEL);
> > -	if (!timers)
> > -		return -ENOMEM;
> > -
> > -	ret = acpi_arch_timer_mem_init(timers, &timer_count);
> 
> You probably already noticed (I was checking the initcall level in
> drivers/acpi/arm64/gtdt.c to start sorting out GICv5 IWB dependencies),
> AFAICS acpi_arch_timer_mem_init() is now unused so it can be removed.

See https://lore.kernel.org/r/20251030110137.1843007-1-maz@kernel.org

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.