linux-kernel - Re: maple_tree.c:3738:1: error: the frame size of 1040 bytes is larger than 1024 bytes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <34a85c92-7355-1330-3eb4-ad2cec737764@nerdbynature.de>
Date: Thu, 30 Oct 2025 18:25:21 +0100 (CET)
From: Christian Kujau <lists@...dbynature.de>
To: David Laight <david.laight.linux@...il.com>
cc: linux-kernel@...r.kernel.org, "Liam R. Howlett" <Liam.Howlett@...cle.com>, 
    Arnd Bergmann <arnd@...db.de>
Subject: Re: maple_tree.c:3738:1: error: the frame size of 1040 bytes is
 larger than 1024 bytes

On Thu, 30 Oct 2025, Christian Kujau wrote:
> > Oh, and the WARN_ON_ONCE() in there is all wrong.
> > A WARN_ON_ONCE(type != wr_split_store) after the call to mas_rebalance()
> > might make sense.
> 
> I'll leave that for someone else to fix :-)

OK, something like this maybe, but I don't understand this, so it doesn't 
feel right to propose this myself.

diff --git a/lib/maple_tree.c b/lib/maple_tree.c
index 949fd2a0554b..6158933cfd01 100644
--- a/lib/maple_tree.c
+++ b/lib/maple_tree.c
@@ -3062,11 +3062,11 @@ static noinline_for_kasan void mas_commit_b_node(struct ma_wr_state *wr_mas,
 {
 	enum store_type type = wr_mas->mas->store_type;
 
-	WARN_ON_ONCE(type != wr_rebalance && type != wr_split_store);
-
 	if (type == wr_rebalance)
 		return mas_rebalance(wr_mas->mas, b_node);
 
+	WARN_ON_ONCE(type != wr_split_store);
+
 	return mas_split(wr_mas->mas, b_node);
 }

Christian.
-- 
BOFH excuse #135:

You put the disk in upside down.