linux-kernel - Re: [PATCH RESEND v2 06/12] coco: host: arm64: Add RMM device communication helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251030180243.0000751b@huawei.com>
Date: Thu, 30 Oct 2025 18:02:43 +0000
From: Jonathan Cameron <jonathan.cameron@...wei.com>
To: Aneesh Kumar K.V <aneesh.kumar@...nel.org>
CC: <linux-coco@...ts.linux.dev>, <kvmarm@...ts.linux.dev>,
	<linux-pci@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<dan.j.williams@...el.com>, <aik@....com>, <lukas@...ner.de>, Samuel Ortiz
	<sameo@...osinc.com>, Xu Yilun <yilun.xu@...ux.intel.com>, Jason Gunthorpe
	<jgg@...pe.ca>, Suzuki K Poulose <Suzuki.Poulose@....com>, Steven Price
	<steven.price@....com>, Bjorn Helgaas <helgaas@...nel.org>, Catalin Marinas
	<catalin.marinas@....com>, Marc Zyngier <maz@...nel.org>, Will Deacon
	<will@...nel.org>, Oliver Upton <oliver.upton@...ux.dev>
Subject: Re: [PATCH RESEND v2 06/12] coco: host: arm64: Add RMM device
 communication helpers

On Thu, 30 Oct 2025 19:34:51 +0530
"Aneesh Kumar K.V" <aneesh.kumar@...nel.org> wrote:

> Jonathan Cameron <jonathan.cameron@...wei.com> writes:
> 
> > On Mon, 27 Oct 2025 15:25:56 +0530
> > "Aneesh Kumar K.V (Arm)" <aneesh.kumar@...nel.org> wrote:
> >  
> 
> ...
> 
> >> +void pdev_communicate_work(struct work_struct *work)
> >> +{
> >> +	unsigned long state;
> >> +	struct pci_tsm *tsm;
> >> +	struct dev_comm_work *setup_work;
> >> +	struct cca_host_pf0_dsc *pf0_dsc;
> >> +
> >> +	setup_work = container_of(work, struct dev_comm_work, work);
> >> +	tsm = setup_work->tsm;
> >> +	pf0_dsc = to_cca_pf0_dsc(tsm->dsm_dev);  
> > Could combine these 3 with declarations for shorter code without much
> > change to readability.
> >  
> 
> Not sure about this.
> 
>  static void pdev_communicate_work(struct work_struct *work)
>  {
>  	unsigned long state;
> -	struct pci_tsm *tsm;
> -	struct dev_comm_work *setup_work;
> -	struct cca_host_pf0_dsc *pf0_dsc;
> -
> -	setup_work = container_of(work, struct dev_comm_work, work);
> -	tsm = setup_work->tsm;
> -	pf0_dsc = to_cca_pf0_dsc(tsm->dsm_dev);
> +	struct dev_comm_work *setup_work = container_of(work,
> +							struct dev_comm_work,
> +							work);
> +	struct pci_tsm *tsm = setup_work->tsm;
> +	struct cca_host_pf0_dsc *pf0_dsc = to_cca_pf0_dsc(tsm->dsm_dev);
I'd wrap it a bit differently.  

	struct dev_comm_work *setup_work =
		container_of(work, struct dev_comm_work, work);
	struct pci_tsm *tsm = setup_work->tsm;
	struct cca_host_pf0_dsc *pf0_dsc = to_cca_pf0_dsc(tsm->dsm_dev);

Entirely up to you. Hence the could part of the comment.

Jonathan