linux-kernel - Re: [PATCH 0/2] mfd: syscon: introduce no-auto-mmio DT property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251030182138.GB130921-robh@kernel.org>
Date: Thu, 30 Oct 2025 13:21:38 -0500
From: Rob Herring <robh@...nel.org>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Chen-Yu Tsai <wens@...nel.org>, Arnd Bergmann <arnd@...db.de>,
	John Madieu <john.madieu.xa@...renesas.com>,
	Lee Jones <lee@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
	devicetree@...r.kernel.org,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	linux-kernel@...r.kernel.org,
	André Draszik <andre.draszik@...aro.org>,
	Peter Griffin <peter.griffin@...aro.org>
Subject: Re: [PATCH 0/2] mfd: syscon: introduce no-auto-mmio DT property

On Thu, Oct 30, 2025 at 04:09:52PM +0300, Dan Carpenter wrote:
> Yeah.  Let me send this tommorrow if no one objects.  Pretty simple
> solution in retrospect.
> 
> [PATCH] mfd: syscon: Return -EPROBE_DEFER in device_node_get_regmap()
> 
> These days we can register syscons with of_syscon_register_regmap() so
> if we can't find the syscon that probably means it hasn't been registered
> yet.  Return -EPROBE_DEFER so the driver will try probing again.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>  drivers/mfd/syscon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Acked-by: Rob Herring (Arm) <robh@...nel.org>

> diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c
> index ae71a2710bed..e5d5def594f6 100644
> --- a/drivers/mfd/syscon.c
> +++ b/drivers/mfd/syscon.c
> @@ -183,7 +183,7 @@ static struct regmap *device_node_get_regmap(struct device_node *np,
>  		if (create_regmap)
>  			syscon = of_syscon_register(np, check_res);
>  		else
> -			syscon = ERR_PTR(-EINVAL);
> +			syscon = ERR_PTR(-EPROBE_DEFER);
>  	}
>  	mutex_unlock(&syscon_list_lock);
>  
> -- 
> 2.51.0
>