linux-kernel - [PATCH] MIPS: Loongson64: Use pointer from memcpy() call for assignment in loongson_kexec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <037fcb01-b723-42f3-b3e8-9a351e1caa47@web.de>
Date: Thu, 30 Oct 2025 20:57:29 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: linux-mips@...r.kernel.org, Huacai Chen <chenhuacai@...nel.org>,
 Jiaxun Yang <jiaxun.yang@...goat.com>, Jinyang He <hejinyang@...ngson.cn>,
 Thomas Bogendörfer <tsbogend@...ha.franken.de>,
 Youling Tang <tangyouling@...ngson.cn>
Cc: LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org,
 Eric Biederman <ebiederm@...ssion.com>, Miaoqian Lin <linmq006@...il.com>
Subject: [PATCH] MIPS: Loongson64: Use pointer from memcpy() call for
 assignment in loongson_kexec_prepare()

From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Thu, 30 Oct 2025 20:48:11 +0100

A pointer was assigned to a variable. The same pointer was used for
the destination parameter of a memcpy() call.
This function is documented in the way that the same value is returned.
Thus convert two separate statements into a direct variable assignment for
the return value from a memory copy action.

The source code was transformed by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
 arch/mips/loongson64/reset.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/mips/loongson64/reset.c b/arch/mips/loongson64/reset.c
index 3e20ade0503a..ce412f5616b7 100644
--- a/arch/mips/loongson64/reset.c
+++ b/arch/mips/loongson64/reset.c
@@ -76,8 +76,9 @@ static int loongson_kexec_prepare(struct kimage *image)
 			 * of parameters (as bootloader does).
 			 */
 			int offt;
-			str = (char *)argv + KEXEC_ARGV_SIZE/2;
-			memcpy(str, image->segment[i].buf, KEXEC_ARGV_SIZE/2);
+
+			str = memcpy((char *)argv + KEXEC_ARGV_SIZE / 2, image->segment[i].buf,
+				     KEXEC_ARGV_SIZE / 2);
 			ptr = strchr(str, ' ');
 
 			while (ptr && (argc < MAX_ARGS)) {
-- 
2.51.1