linux-kernel - Re: [PATCH v2 1/3] dt-bindings: mfd: twl: enable power button also for twl603x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251030-scientist-splashed-e0505d44abc4@spud>
Date: Thu, 30 Oct 2025 19:59:59 +0000
From: Conor Dooley <conor@...nel.org>
To: akemnade@...nel.org
Cc: Lee Jones <lee@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Andreas Kemnade <andreas@...nade.info>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Tony Lindgren <tony@...mide.com>, Kevin Hilman <khilman@...nel.org>,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-input@...r.kernel.org, linux-omap@...r.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: mfd: twl: enable power button also
 for twl603x

On Thu, Oct 30, 2025 at 08:10:34PM +0100, akemnade@...nel.org wrote:
> From: Andreas Kemnade <andreas@...nade.info>
> 
> TWL603x has also a power button function, so add the corresponding subnode.
> As not in all cases there is a power button connected to the corresponding
> pad of the TWL603x, the functionality can be disabled by
> status = "disabled" or simply not adding the subnode.
> To keep things simple, follow the established design pattern of using const
> interrupts as used also by the other subdevices.
> 
> Signed-off-by: Andreas Kemnade <andreas@...nade.info>

> @@ -225,12 +248,8 @@ properties:
>      additionalProperties: false
>  
>      properties:
> -      compatible:
> -        const: ti,twl4030-pwrbutton
> -      interrupts:
> -        items:
> -          - items:
> -              const: 8
> +      compatible: true
> +      interrupts: true

I think this should be
    properties:
      compatible:
        enum:
          - ti,twl4030-pwrbutton
          - ti,twl6030-pwrbutton
      interrupts:
        maxItems: 1
since we want to keep the widest constraints that apply at the outer
level, rather than removing the constraints entirely.

pw-bot: changes-requested

Cheers,
Conor.

>  
>    watchdog:
>      type: object
> @@ -459,6 +478,11 @@ examples:
>            #io-channel-cells = <1>;
>          };
>  
> +        pwrbutton {
> +          compatible = "ti,twl6030-pwrbutton";
> +          interrupts = <0>;
> +        };
> +
>          rtc {
>            compatible = "ti,twl4030-rtc";
>            interrupts = <8>;
> 
> -- 
> 2.47.3
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)