linux-kernel - Re: [PATCH v2 3/3] firmware: stratix10-svc: add the compatible value for Agilex5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eef97a92-40ea-429d-8bc4-6fb22f05d2a7@altera.com>
Date: Thu, 30 Oct 2025 23:08:25 +0000
From: "Romli, Khairul Anuar" <khairul.anuar.romli@...era.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
CC: Dinh Nguyen <dinguyen@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
	"Rao, Mahesh" <mahesh.rao@...era.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>
Subject: Re: [PATCH v2 3/3] firmware: stratix10-svc: add the compatible value
 for Agilex5

On 31/10/2025 12:33 am, Krzysztof Kozlowski wrote:
> On 30/10/2025 12:35, Romli, Khairul Anuar wrote:
>> On 30/10/2025 3:58 pm, Krzysztof Kozlowski wrote:
>>> On Thu, Oct 30, 2025 at 11:30:09AM +0800, Khairul Anuar Romli wrote:
>>>> Add the compatible property value so we can reuse Intel Stratix10
>>>> Service Layer driver on Intel Agilex5 SoC platform.
>>>>
>>>> This addition is an initial Agilex5 service layer driver enablement that
>>>> will involve adding IOMMU changes in the future.
>>>
>>> Heh, your bindings said now there is no iommu. Can you please read
>>> writing bindings before you post next version?
>>>
>>> Best regards,
>>> Krzysztof
>>>
>> I was excluding the iommu in the current patch series, not that I meant
>> there is no iommu. It was meant for the future patches that will include
> 
> Read your bindings again. They clearly do not list IOMMU, meaning there
> is no IOMMU.
> 
> Best regards,
> Krzysztof

I will add that in the next revision also after going through 
https://www.kernel.org/doc/Documentation/devicetree/bindings/writing-bindings.rst

One question, if the property only meant for a specific compatible, do 
you accept the logical "if" statement to ensure that the property only 
for specific device but not others?

Thanks.

Best Regards,
Khairul