linux-kernel - Re: [PATCH net] selftests: netdevsim: Fix ethtool-features.sh fail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aQPxN5lQui5j8nK8@krikkit>
Date: Fri, 31 Oct 2025 00:13:59 +0100
From: Sabrina Dubroca <sd@...asysnail.net>
To: Wang Liang <wangliang74@...wei.com>
Cc: kuba@...nel.org, andrew@...n.ch, davem@...emloft.net,
	edumazet@...gle.com, pabeni@...hat.com, shuah@...nel.org,
	horms@...nel.org, netdev@...r.kernel.org,
	linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
	yuehaibing@...wei.com, zhangchangzhong@...wei.com
Subject: Re: [PATCH net] selftests: netdevsim: Fix ethtool-features.sh fail

2025-10-30, 11:22:03 +0800, Wang Liang wrote:
> This patch adds executable permission to script 'ethtool-features.sh', and
> check 'ethtool --json -k' support. 

Those are two separate things, probably should be two separate patches.

[...]
> @@ -7,6 +7,11 @@ NSIM_NETDEV=$(make_netdev)
>  
>  set -o pipefail
>  
> +if ! ethtool --json -k $NSIM_NETDEV > /dev/null 2>&1; then

I guess it's improving the situation, but I've got a system with an
ethtool that accepts the --json argument, but silently ignores it for
 -k (ie `ethtool --json -k $DEV` succeeds but doesn't produce a json
output), which will still cause the test to fail later.

-- 
Sabrina