linux-kernel - Re: [PATCH v23 4/9] sched: Add assert_balance_callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a0d1ab59-1f2b-4410-9396-3fddf4865bac@amd.com>
Date: Thu, 30 Oct 2025 13:08:15 +0530
From: K Prateek Nayak <kprateek.nayak@....com>
To: John Stultz <jstultz@...gle.com>, LKML <linux-kernel@...r.kernel.org>
CC: Peter Zijlstra <peterz@...radead.org>, Joel Fernandes
	<joelagnelf@...dia.com>, Qais Yousef <qyousef@...alina.io>, Ingo Molnar
	<mingo@...hat.com>, Juri Lelli <juri.lelli@...hat.com>, Vincent Guittot
	<vincent.guittot@...aro.org>, Dietmar Eggemann <dietmar.eggemann@....com>,
	Valentin Schneider <vschneid@...hat.com>, Steven Rostedt
	<rostedt@...dmis.org>, Ben Segall <bsegall@...gle.com>, Zimuzo Ezeozue
	<zezeozue@...gle.com>, Mel Gorman <mgorman@...e.de>, Will Deacon
	<will@...nel.org>, Waiman Long <longman@...hat.com>, Boqun Feng
	<boqun.feng@...il.com>, "Paul E. McKenney" <paulmck@...nel.org>, Metin Kaya
	<Metin.Kaya@....com>, Xuewen Yan <xuewen.yan94@...il.com>, Thomas Gleixner
	<tglx@...utronix.de>, Daniel Lezcano <daniel.lezcano@...aro.org>, "Suleiman
 Souhlal" <suleiman@...gle.com>, kuyo chang <kuyo.chang@...iatek.com>, hupu
	<hupu.gm@...il.com>, <kernel-team@...roid.com>
Subject: Re: [PATCH v23 4/9] sched: Add assert_balance_callbacks_empty helper

Hello John,

On 10/30/2025 5:48 AM, John Stultz wrote:
> +#ifdef CONFIG_PROVE_LOCKING
> +static inline void assert_balance_callbacks_empty(struct rq *rq)
> +{
> +	WARN_ON_ONCE(rq->balance_callback && rq->balance_callback != &balance_push_callback);

Can we instead use "IS_ENABLED(CONFIG_PROVE_LOCKING) && ..." and avoid
the empty stub?

I see similar pattern used inside WARN_ON_ONCE() by RCU and
context-tracking bits so I'm assuming compiler is smart enough to
optimize it out when the config is disabled :)

Apart from that nit, feel free to include:

Reviewed-by: K Prateek Nayak <kprateek.nayak@....com>

> +}
> +#else
> +static inline void assert_balance_callbacks_empty(struct rq *rq) {}
> +#endif
> +

-- 
Thanks and Regards,
Prateek