linux-kernel - Re: [PATCH v2 3/3] firmware: stratix10-svc: add the compatible value for Agilex5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251030-pastoral-discerning-goldfish-e8f3bb@kuoka>
Date: Thu, 30 Oct 2025 08:57:41 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Khairul Anuar Romli <khairul.anuar.romli@...era.com>
Cc: Dinh Nguyen <dinguyen@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Mahesh Rao <mahesh.rao@...era.com>, linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v2 3/3] firmware: stratix10-svc: add the compatible value
 for Agilex5

On Thu, Oct 30, 2025 at 11:30:09AM +0800, Khairul Anuar Romli wrote:
> Add the compatible property value so we can reuse Intel Stratix10
> Service Layer driver on Intel Agilex5 SoC platform.
> 
> This addition is an initial Agilex5 service layer driver enablement that
> will involve adding IOMMU changes in the future.
> 
> Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@...era.com>
> ---
> Changes in v2:
> 	- Add driver compatible for Agilex5-svc
> ---
>  drivers/firmware/stratix10-svc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/firmware/stratix10-svc.c b/drivers/firmware/stratix10-svc.c
> index e3f990d888d7..afc6c8b43e98 100644
> --- a/drivers/firmware/stratix10-svc.c
> +++ b/drivers/firmware/stratix10-svc.c
> @@ -1117,6 +1117,7 @@ EXPORT_SYMBOL_GPL(stratix10_svc_free_memory);
>  static const struct of_device_id stratix10_svc_drv_match[] = {
>  	{.compatible = "intel,stratix10-svc"},
>  	{.compatible = "intel,agilex-svc"},
> +	{.compatible = "intel,agilex5-svc"},

So device is fully compatible - drop this change and express
compatibility in the bindings (see writing bindings, writing schema or
slides from my last OSSE talk).

Best regards,
Krzysztof