linux-kernel - Re: [PATCH 1/4] ACPI: GTDT: Generate platform devices for MMIO timers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1eafe745-068b-4c15-a3d0-14e7222970fd@quicinc.com>
Date: Thu, 30 Oct 2025 13:40:31 +0530
From: Pavan Kondeti <pavan.kondeti@....qualcomm.com>
To: Marc Zyngier <maz@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        Hanjun Guo <guohanjun@...wei.com>, Sudeep Holla <sudeep.holla@....com>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Mark Rutland <mark.rutland@....com>
Subject: Re: [PATCH 1/4] ACPI: GTDT: Generate platform devices for MMIO timers

On Thu, Aug 07, 2025 at 05:02:40PM +0100, Marc Zyngier wrote:
> In preparation for the MMIO timer support code becoming an actual
> driver, mimic what is done for the SBSA watchdog and expose
> a synthetic device for each MMIO timer block.
> 
> Signed-off-by: Marc Zyngier <maz@...nel.org>
> ---
>  drivers/acpi/arm64/gtdt.c | 29 +++++++++++++++++++++++++----
>  1 file changed, 25 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/acpi/arm64/gtdt.c b/drivers/acpi/arm64/gtdt.c
> index 70f8290b659de..fd995a1d3d248 100644
> --- a/drivers/acpi/arm64/gtdt.c
> +++ b/drivers/acpi/arm64/gtdt.c
> @@ -388,11 +388,11 @@ static int __init gtdt_import_sbsa_gwdt(struct acpi_gtdt_watchdog *wd,
>  	return 0;
>  }
>  
> -static int __init gtdt_sbsa_gwdt_init(void)
> +static int __init gtdt_platform_timer_init(void)
>  {
>  	void *platform_timer;
>  	struct acpi_table_header *table;
> -	int ret, timer_count, gwdt_count = 0;
> +	int ret, timer_count, gwdt_count = 0, mmio_timer_count = 0;
>  
>  	if (acpi_disabled)
>  		return 0;
> @@ -414,20 +414,41 @@ static int __init gtdt_sbsa_gwdt_init(void)
>  		goto out_put_gtdt;
>  
>  	for_each_platform_timer(platform_timer) {
> +		ret = 0;
> +
>  		if (is_non_secure_watchdog(platform_timer)) {
>  			ret = gtdt_import_sbsa_gwdt(platform_timer, gwdt_count);
>  			if (ret)
> -				break;
> +				continue;
>  			gwdt_count++;
> +		} else 	if (is_timer_block(platform_timer)) {
> +			struct arch_timer_mem atm = {};
> +			struct platform_device *pdev;
> +
> +			ret = gtdt_parse_timer_block(platform_timer, &atm);
> +			if (ret)
> +				continue;
> +
> +			pdev = platform_device_register_data(NULL, "gtdt-arm-mmio-timer",
> +							     gwdt_count, &atm,
> +							     sizeof(atm));

Did you mean to pass `mmio_timer_count` as the `id` argument to
platform_device_register_data()?


> +			if (IS_ERR(pdev)) {
> +				pr_err("Can't register timer %d\n", gwdt_count);
> +				continue;
> +			}

and here too.

Thanks,
Pavan