linux-kernel - Re: [PATCH 1/9] PCI: Prevent resource tree corruption when BAR resize fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d697c9e1-580e-6449-796c-a3f5198e0934@linux.intel.com>
Date: Thu, 30 Oct 2025 10:22:27 +0200 (EET)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Bjorn Helgaas <helgaas@...nel.org>
cc: Alex Bennée <alex.bennee@...aro.org>, 
    Simon Richter <Simon.Richter@...yros.de>, 
    Lucas De Marchi <lucas.demarchi@...el.com>, 
    Alex Deucher <alexander.deucher@....com>, amd-gfx@...ts.freedesktop.org, 
    Bjorn Helgaas <bhelgaas@...gle.com>, David Airlie <airlied@...il.com>, 
    dri-devel@...ts.freedesktop.org, intel-gfx@...ts.freedesktop.org, 
    intel-xe@...ts.freedesktop.org, Jani Nikula <jani.nikula@...ux.intel.com>, 
    Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>, 
    linux-pci@...r.kernel.org, Rodrigo Vivi <rodrigo.vivi@...el.com>, 
    Simona Vetter <simona@...ll.ch>, Tvrtko Ursulin <tursulin@...ulin.net>, 
    Christian König <christian.koenig@....com>, 
    Thomas Hellström <thomas.hellstrom@...ux.intel.com>, 
    Michał Winiarski <michal.winiarski@...el.com>, 
    LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/9] PCI: Prevent resource tree corruption when BAR resize
 fails

On Wed, 29 Oct 2025, Bjorn Helgaas wrote:

> On Tue, Oct 28, 2025 at 07:35:43PM +0200, Ilpo Järvinen wrote:
> > pbus_reassign_bridge_resources() saves bridge windows into the saved
> > list before attempting to adjust resource assignments to perform a BAR
> > resize operation. If resource adjustments cannot be completed fully,
> > rollback is attempted by restoring the resource from the saved list.
> 
> > Fixes: 8bb705e3e79d ("PCI: Add pci_resize_resource() for resizing BARs")
> > Reported-by: Simon Richter <Simon.Richter@...yros.de>
> > Reported-by: Alex Bennée <alex.bennee@...aro.org>
> 
> If these reports were public, can we include lore URLs for them?
> 
> Same question for [PATCH 5/9] PCI: Fix restoring BARs on BAR resize
> rollback path.
> 
> I put these all on pci/resource for build testing.  I assume we'll
> tweak these based on testing reports and sorting out the pci/rebar
> conflicts.

Thanks, the links will come in v2 along with fixing a few things found by 
more extensive tests by LKP. E.g., it seems clang thinks guard() cannot be 
used here because goto jumps over it (auto variable initialization gets 
skipped so it's kind of understandable limitation).

-- 
 i.