linux-kernel - Re: [PATCH 03/21] select: rename BITS() to FDS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4drjqnnq6gt7wrltl744fob4wyrhrohmbq5p5iesktxjxc2leb@sj3nbutobr5t>
Date: Thu, 30 Oct 2025 10:42:15 +0100
From: Jan Kara <jack@...e.cz>
To: "Yury Norov (NVIDIA)" <yury.norov@...il.com>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>, 
	Linus Walleij <linus.walleij@...aro.org>, Nicolas Frattaroli <nicolas.frattaroli@...labora.com>, 
	Alexander Viro <viro@...iv.linux.org.uk>, Christian Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>, 
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Rasmus Villemoes <linux@...musvillemoes.dk>
Subject: Re: [PATCH 03/21] select: rename BITS() to FDS_BITS()

On Sat 25-10-25 12:40:02, Yury Norov (NVIDIA) wrote:
> In preparation for adding generic BITS() macro, rename the local one.
> 
> Signed-off-by: Yury Norov (NVIDIA) <yury.norov@...il.com>

Looks fine. Feel free to add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  fs/select.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/select.c b/fs/select.c
> index 082cf60c7e23..ad5bfb4907ea 100644
> --- a/fs/select.c
> +++ b/fs/select.c
> @@ -412,7 +412,7 @@ void zero_fd_set(unsigned long nr, unsigned long *fdset)
>  #define FDS_OUT(fds, n)		(fds->out + n)
>  #define FDS_EX(fds, n)		(fds->ex + n)
>  
> -#define BITS(fds, n)	(*FDS_IN(fds, n)|*FDS_OUT(fds, n)|*FDS_EX(fds, n))
> +#define FDS_BITS(fds, n)	(*FDS_IN(fds, n)|*FDS_OUT(fds, n)|*FDS_EX(fds, n))
>  
>  static int max_select_fd(unsigned long n, fd_set_bits *fds)
>  {
> @@ -428,7 +428,7 @@ static int max_select_fd(unsigned long n, fd_set_bits *fds)
>  	open_fds = fdt->open_fds + n;
>  	max = 0;
>  	if (set) {
> -		set &= BITS(fds, n);
> +		set &= FDS_BITS(fds, n);
>  		if (set) {
>  			if (!(set & ~*open_fds))
>  				goto get_max;
> @@ -438,7 +438,7 @@ static int max_select_fd(unsigned long n, fd_set_bits *fds)
>  	while (n) {
>  		open_fds--;
>  		n--;
> -		set = BITS(fds, n);
> +		set = FDS_BITS(fds, n);
>  		if (!set)
>  			continue;
>  		if (set & ~*open_fds)
> -- 
> 2.43.0
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR