linux-kernel - Re: [PATCH v1] tools/rtla: Fix unassigned nr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251030060016.0d58fe5d@gandalf.local.home>
Date: Thu, 30 Oct 2025 06:00:16 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Tomas Glozar <tglozar@...hat.com>
Cc: Costa Shulyupin <costa.shul@...hat.com>, Crystal Wood
 <crwood@...hat.com>, John Kacur <jkacur@...hat.com>,
 linux-trace-kernel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] tools/rtla: Fix unassigned nr_cpus

On Thu, 30 Oct 2025 10:10:36 +0100
Tomas Glozar <tglozar@...hat.com> wrote:

> Hi Steven,
> 
> čt 2. 10. 2025 v 19:09 odesílatel Costa Shulyupin
> <costa.shul@...hat.com> napsal:
> >
> > In recently introduced timerlat_free(),
> > the variable 'nr_cpus' is not assigned.
> >
> > Assign it with sysconf(_SC_NPROCESSORS_CONF) as done elsewhere.
> > Remove the culprit: -Wno-maybe-uninitialized. The rest of the
> > code is clean.
> >
> > Signed-off-by: Costa Shulyupin <costa.shul@...hat.com>
> > ---
> >  tools/tracing/rtla/Makefile.rtla  | 2 +-
> >  tools/tracing/rtla/src/timerlat.c | 3 ++-
> >  2 files changed, 3 insertions(+), 2 deletions(-)
> >  
> 
> This is another fix of a bug introduced in the 6.18-v1 RTLA code
> consolidation [1], this time affecting the resetting of idle states
> set through --deepest-idle-state. Could you please also add it to your
> RTLA fix queue?
> 
> Also, this should have:
> 
> Fixes: 2f3172f9dd58 ("tools/rtla: Consolidate code between
> osnoise/timerlat and hist/top")
> 
> [1] https://lore.kernel.org/linux-trace-kernel/20250907022325.243930-1-crwood@redhat.com/T/
>

Thanks,

I'll take a look at this today. We need to start making you a maintainer
for this, so that you only need to send me pull requests.

Do you have a kernel.org account? If not, do you have PGP signatures from
other kernel.org developers to your key?

-- Steve