linux-kernel - Re: [PATCH v3 2/2] gpu: nova-core: add boot42 support for next-gen GPUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5fabf22d-1aec-42d2-99b5-fa13dcc94950@nvidia.com>
Date: Wed, 29 Oct 2025 18:09:01 -0700
From: John Hubbard <jhubbard@...dia.com>
To: Alexandre Courbot <acourbot@...dia.com>,
 Danilo Krummrich <dakr@...nel.org>
Cc: Joel Fernandes <joelagnelf@...dia.com>, Timur Tabi <ttabi@...dia.com>,
 Alistair Popple <apopple@...dia.com>, Edwin Peer <epeer@...dia.com>,
 Zhi Wang <zhiw@...dia.com>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>, Bjorn Helgaas <bhelgaas@...gle.com>,
 Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>,
 Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>,
 Benno Lossin <lossin@...nel.org>, Andreas Hindborg <a.hindborg@...nel.org>,
 Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>,
 nouveau@...ts.freedesktop.org, rust-for-linux@...r.kernel.org,
 LKML <linux-kernel@...r.kernel.org>,
 Nouveau <nouveau-bounces@...ts.freedesktop.org>
Subject: Re: [PATCH v3 2/2] gpu: nova-core: add boot42 support for next-gen
 GPUs

On 10/29/25 5:54 PM, Alexandre Courbot wrote:
> On Thu Oct 30, 2025 at 9:37 AM JST, John Hubbard wrote:
>> On 10/29/25 6:54 AM, Alexandre Courbot wrote:
>>> On Wed Oct 29, 2025 at 8:26 PM JST, Danilo Krummrich wrote:
>>> <snip>
>> ...
>>
>> Done. Final code snippet looks like this:
>>
>>          let boot0 = regs::NV_PMC_BOOT_0::read(bar);
>>
>>          if boot0.use_boot42_instead() {
>>              Spec::try_from(regs::NV_PMC_BOOT_42::read(bar))
>>          } else {
>>              Spec::try_from(boot0)
>>          }
> 
> The previous code was returning `ENODEV` in case of NV04, aren't we
> losing this? Or is it moved to BOOT0's `try_from`?

Exactly, this is by intention now. We can fully determine the answers
via .use_boot42_instead(). The nv04 check is redundant.

thanks,
John Hubbard