linux-kernel - Re: [PATCH v5 02/23] crypto: qat - #undef field

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aQM+QPi7KqN8Nuu6@gcabiddu-mobl.ger.corp.intel.com>
Date: Thu, 30 Oct 2025 10:30:24 +0000
From: Giovanni Cabiddu <giovanni.cabiddu@...el.com>
To: Geert Uytterhoeven <geert+renesas@...der.be>
CC: Michael Turquette <mturquette@...libre.com>, Stephen Boyd
	<sboyd@...nel.org>, Nicolas Ferre <nicolas.ferre@...rochip.com>, "Alexandre
 Belloni" <alexandre.belloni@...tlin.com>, Claudiu Beznea
	<claudiu.beznea@...on.dev>, Herbert Xu <herbert@...dor.apana.org.au>, "David
 Miller" <davem@...emloft.net>, Linus Walleij <linus.walleij@...aro.org>,
	Bartosz Golaszewski <brgl@...ev.pl>, Joel Stanley <joel@....id.au>, "Andrew
 Jeffery" <andrew@...econstruct.com.au>, Crt Mori <cmo@...exis.com>, "Jonathan
 Cameron" <jic23@...nel.org>, Lars-Peter Clausen <lars@...afoo.de>, Jacky
 Huang <ychuang3@...oton.com>, Shan-Chun Hung <schung@...oton.com>, Yury Norov
	<yury.norov@...il.com>, Rasmus Villemoes <linux@...musvillemoes.dk>,
	"Jaroslav Kysela" <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, Johannes
 Berg <johannes@...solutions.net>, Jakub Kicinski <kuba@...nel.org>, Alex
 Elder <elder@...e.org>, David Laight <david.laight.linux@...il.com>, "Vincent
 Mailhol" <mailhol.vincent@...adoo.fr>, Jason Baron <jbaron@...mai.com>,
	Borislav Petkov <bp@...en8.de>, Tony Luck <tony.luck@...el.com>, "Michael
 Hennerich" <Michael.Hennerich@...log.com>, Kim Seer Paller
	<kimseer.paller@...log.com>, David Lechner <dlechner@...libre.com>, Nuno
 Sá <nuno.sa@...log.com>, Andy Shevchenko
	<andy@...nel.org>, Richard Genoud <richard.genoud@...tlin.com>, "Cosmin
 Tanislav" <demonsingur@...il.com>, Biju Das <biju.das.jz@...renesas.com>,
	Jianping Shen <Jianping.Shen@...bosch.com>, <linux-clk@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-renesas-soc@...r.kernel.org>,
	<linux-crypto@...r.kernel.org>, <linux-edac@...r.kernel.org>,
	<qat-linux@...el.com>, <linux-gpio@...r.kernel.org>,
	<linux-aspeed@...ts.ozlabs.org>, <linux-iio@...r.kernel.org>,
	<linux-sound@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 02/23] crypto: qat - #undef field_get() before local
 definition

On Mon, Oct 27, 2025 at 07:41:36PM +0100, Geert Uytterhoeven wrote:
> Prepare for the advent of a globally available common field_get() macro
> by undefining the symbol before defining a local variant.  This prevents
> redefinition warnings from the C preprocessor when introducing the common
> macro later.
> 
> Suggested-by: Yury Norov <yury.norov@...il.com>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
Acked-by: Giovanni Cabiddu <giovanni.cabiddu@...el.com>

> --
> v5:
>   - New.
> ---
>  drivers/crypto/intel/qat/qat_common/adf_pm_dbgfs_utils.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/crypto/intel/qat/qat_common/adf_pm_dbgfs_utils.c b/drivers/crypto/intel/qat/qat_common/adf_pm_dbgfs_utils.c
> index 69295a9ddf0ac92f..6186fafb4a7b0dab 100644
> --- a/drivers/crypto/intel/qat/qat_common/adf_pm_dbgfs_utils.c
> +++ b/drivers/crypto/intel/qat/qat_common/adf_pm_dbgfs_utils.c
> @@ -11,6 +11,7 @@
>   * pm_scnprint_table(), making it not compile time constant, so the compile
>   * asserts from FIELD_GET() or u32_get_bits() won't be fulfilled.
>   */
> +#undef field_get
>  #define field_get(_mask, _reg) (((_reg) & (_mask)) >> (ffs(_mask) - 1))
>  
>  #define PM_INFO_MAX_KEY_LEN	21
> -- 
> 2.43.0
>