linux-kernel - Re: [PATCH v2] HID: lenovo: fixup Lenovo Yoga Slim 7x Keyboard rdesc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5r0q48r7-6o9s-0831-s9n8-8qo0q6140op6@xreary.bet>
Date: Thu, 30 Oct 2025 11:41:28 +0100 (CET)
From: Jiri Kosina <jikos@...nel.org>
To: Lauri Tirkkonen <lauri@...ktheplanet.fi>
cc: Benjamin Tissoires <bentiss@...nel.org>, linux-input@...r.kernel.org, 
    linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] HID: lenovo: fixup Lenovo Yoga Slim 7x Keyboard
 rdesc

On Sat, 18 Oct 2025, Lauri Tirkkonen wrote:

> The keyboard of this device has the following in its report description
> for Usage (Keyboard) in Collection (Application):
> 
> 	# 0x15, 0x00,                    //  Logical Minimum (0)                52
> 	# 0x25, 0x65,                    //  Logical Maximum (101)              54
> 	# 0x05, 0x07,                    //  Usage Page (Keyboard)              56
> 	# 0x19, 0x00,                    //  Usage Minimum (0)                  58
> 	# 0x29, 0xdd,                    //  Usage Maximum (221)                60
> 	# 0x81, 0x00,                    //  Input (Data,Arr,Abs)               62
> 
> Since the Usage Min/Max range exceeds the Logical Min/Max range,
> keypresses outside the Logical range are not recognized. This includes,
> for example, the Japanese language keyboard variant's keys for |, _ and
> \.
> 
> Fixup the report description to make the Logical range match the Usage
> range, fixing the interpretation of keypresses above 101 on this device.
> 
> Signed-off-by: Lauri Tirkkonen <lauri@...ktheplanet.fi>
> ---
> v1 -> v2: moved to hid-lenovo from hid-i2c, renamed hid-ids macro to
> clarify the device only refers to the keyboard
> 
> v1: https://lore.kernel.org/all/aOdLxAEYQpV2zp77@mail.hacktheplanet.fi/

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs