linux-kernel - Re: [PATCH v2 1/1] firmware: stratix10-svc: fix bug in saving controller data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4e60eee9-5afb-4c97-8c05-96ab39da62b1@kernel.org>
Date: Thu, 30 Oct 2025 06:48:16 -0500
From: Dinh Nguyen <dinguyen@...nel.org>
To: Khairul Anuar Romli <khairul.anuar.romli@...era.com>,
 linux-kernel@...r.kernel.org, Ang Tien Sung <tiensung.ang@...era.com>
Subject: Re: [PATCH v2 1/1] firmware: stratix10-svc: fix bug in saving
 controller data



On 10/29/25 07:31, Khairul Anuar Romli wrote:
> Fix the incorrect usage of platform_set_drvdata and dev_set_drvdata. They
> both are of the same data and overrides each other. This resulted in the
> rmmod of the svc driver to fail and throw a kernel panic for kthread_stop
> and fifo free.
> 
> Fixes: bf0e5bf68a20 ("firmware: stratix10-svc: extend svc to support new RSU features")
> cc: stable@...r.kernel.org # 6.6+

Please read the stable kernel rules documentation for future submissions:

stable-kernel-rules.rst


> Signed-off-by: Ang Tien Sung <tiensung.ang@...era.com>
> Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@...era.com>
> ---
> Changes in v2:
> 	- Add CC that was missed in the v1 and original patch from 2023
> ---
>   drivers/firmware/stratix10-svc.c | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
> 

This patch does not apply cleanly on v6.18-rc1. Please rebase and resubmit.

Thanks,
Dinh