linux-kernel - Re: [PATCH] scripts/decode_stacktrace.sh: fix build ID and PC source parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d08f44d0-1701-4703-ae35-6bb3c871e6eb@kernel.org>
Date: Thu, 30 Oct 2025 13:24:15 +0100
From: Matthieu Baerts <matttbe@...nel.org>
To: Carlos Llamas <cmllamas@...gle.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
 Breno Leitao <leitao@...ian.org>, Luca Ceresoli <luca.ceresoli@...tlin.com>,
 Miroslav Benes <mbenes@...e.cz>, Mark Brown <broonie@...nel.org>,
 Puranjay Mohan <puranjay@...nel.org>, Mark Rutland <mark.rutland@....com>,
 Catalin Marinas <catalin.marinas@....com>, kernel-team@...roid.com,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scripts/decode_stacktrace.sh: fix build ID and PC source
 parsing

Hi Carlos,

Thank you for this fix!

On 30/10/2025 02:03, Carlos Llamas wrote:
> Support for parsing PC source info in stacktraces (e.g. '(P)') was
> added in commit 2bff77c665ed ("scripts/decode_stacktrace.sh: fix
> decoding of lines with an additional info"). However, this logic was
> placed after the build ID processing. This incorrect order fails to
> parse lines containing both elements, e.g.:
> 
>   drm_gem_mmap_obj+0x114/0x200 [drm 03d0564e0529947d67bb2008c3548be77279fd27] (P)
> 
> This patch fixes the problem by extracting the PC source info first and
> then processing the module build ID. With this change, the line above is
> now properly parsed as such:
> 
>   drm_gem_mmap_obj (./include/linux/mmap_lock.h:212 ./include/linux/mm.h:811 drivers/gpu/drm/drm_gem.c:1177) drm (P)
> 
> While here, also add a brief explanation the build ID section.
> 
> Fixes: bdf8eafbf7f5 ("arm64: stacktrace: report source of unwind data")
> Fixes: 2bff77c665ed ("scripts/decode_stacktrace.sh: fix decoding of lines with an additional info")
> Signed-off-by: Carlos Llamas <cmllamas@...gle.com>

LGTM!

Reviewed-by: Matthieu Baerts (NGI0) <matttbe@...nel.org>

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.