linux-kernel - Re: [PATCH v6] backlight: led-backlight: add devlink to supplier LEDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

[an error occurred while processing this directive]

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DDVO7L4Q3GC0.1B3RH5DEQ20HV@bootlin.com>
Date: Thu, 30 Oct 2025 13:54:29 +0100
From: "Luca Ceresoli" <luca.ceresoli@...tlin.com>
To: "Daniel Thompson" <danielt@...nel.org>, "Sverdlin, Alexander"
 <alexander.sverdlin@...mens.com>
Cc: "jingoohan1@...il.com" <jingoohan1@...il.com>, "tomi.valkeinen@...com"
 <tomi.valkeinen@...com>, "lee@...nel.org" <lee@...nel.org>,
 "tony@...mide.com" <tony@...mide.com>, "pavel@....cz" <pavel@....cz>,
 "deller@....de" <deller@....de>, "jjhiblot@...com" <jjhiblot@...com>,
 "linux-fbdev@...r.kernel.org" <linux-fbdev@...r.kernel.org>,
 "thomas.petazzoni@...tlin.com" <thomas.petazzoni@...tlin.com>,
 "saravanak@...gle.com" <saravanak@...gle.com>, "herve.codina@...tlin.com"
 <herve.codina@...tlin.com>, "dri-devel@...ts.freedesktop.org"
 <dri-devel@...ts.freedesktop.org>, "alexander.sverdlin@...il.com"
 <alexander.sverdlin@...il.com>, "linux-kernel@...r.kernel.org"
 <linux-kernel@...r.kernel.org>, "daniel.thompson@...aro.org"
 <daniel.thompson@...aro.org>
Subject: Re: [PATCH v6] backlight: led-backlight: add devlink to supplier
 LEDs

Hello,

On Wed Oct 29, 2025 at 6:45 PM CET, Daniel Thompson wrote:
> On Thu, Oct 23, 2025 at 12:41:30PM +0000, Sverdlin, Alexander wrote:
>> Hi Lee, Daniel, Jingoo,
>>
>> On Mon, 2025-05-19 at 22:19 +0200, Luca Ceresoli wrote:
>> > led-backlight is a consumer of one or multiple LED class devices, but
>> > devlink is currently unable to create correct supplier-producer links when
>> > the supplier is a class device. It creates instead a link where the
>> > supplier is the parent of the expected device.
>> > <snip>
>> > Fixes: ae232e45acf9 ("backlight: add led-backlight driver")
>> > Signed-off-by: Luca Ceresoli <luca.ceresoli@...tlin.com>
>> > Reviewed-by: Herve Codina <herve.codina@...tlin.com>
>>
>> I've noticed that the patch in archived in the patchwork [1] but I wasn't
>> able to find it in any branch of the backlight tree [2].
>>
>> Could it be that the patch somehow slipped through?
>> It does solve a real-world crash, could you please consider to apply it?
>
> Sorry folks. I overlooked this in my backlog and never posted the R-b
> (which helps Lee figure out what to hoover up).
>
> Reviewed-by: Daniel Thompson (RISCstar) <danielt@...nel.org>

Thanks Alexander for pinging and Daniel for reviewing!

I double checked right now and can confirm:

 * the bug is still present on v6.18-rc3
 * the patch applies cleanly on v6.18-rc3
 * the patch is still fixing the bug

Best regards,
Luca

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com