linux-kernel - Re: [PATCH 3/3] slab: use new API for remaining command line parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251030143226.4661857f@mordecai>
Date: Thu, 30 Oct 2025 14:32:26 +0100
From: Petr Tesarik <ptesarik@...e.com>
To: Harry Yoo <harry.yoo@...cle.com>
Cc: Vlastimil Babka <vbabka@...e.cz>, Andrew Morton
 <akpm@...ux-foundation.org>, Christoph Lameter <cl@...two.org>, David
 Rientjes <rientjes@...gle.com>, Roman Gushchin <roman.gushchin@...ux.dev>,
 linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] slab: use new API for remaining command line
 parameters

On Wed, 29 Oct 2025 19:52:46 +0900
Harry Yoo <harry.yoo@...cle.com> wrote:

> On Fri, Oct 24, 2025 at 07:06:54PM +0200, Petr Tesarik wrote:
> > Use core_param() and __core_param_cb() instead of __setup() or
> > __setup_param() to improve syntax checking and error messages.
> > 
> > Replace get_option() with kstrtouint(), because:
> > * the latter accepts a pointer to const char,
> > * these parameters should not accept ranges,
> > * error value can be passed directly to parser.
> > 
> > There is one more change apart from the parsing of numeric parameters:
> > slub_strict_numa parameter name must match exactly. Before this patch the  
> 
> nit: ^ slab_strict_numa

Indeed.

Petr T