linux-kernel - Re: [RFC RFT PATCH] ocfs2: Mark inode bad upon validation failure during read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <stmj7kbqis2idlscf5iwch23ft2azuyyr7q2kmelavjk5lnug4@66in667d6bym>
Date: Fri, 31 Oct 2025 22:05:14 +0800
From: Heming Zhao <heming.zhao@...e.com>
To: Albin Babu Varghese <albinbabuvarghese20@...il.com>
Cc: Ahmet Eray Karadag <eraykrdg1@...il.com>, mark@...heh.com, 
	jlbec@...lplan.org, joseph.qi@...ux.alibaba.com, ocfs2-devel@...ts.linux.dev, 
	linux-kernel@...r.kernel.org, david.hunter.linux@...il.com, skhan@...uxfoundation.org, 
	syzbot+b93b65ee321c97861072@...kaller.appspotmail.com
Subject: Re: [RFC RFT PATCH] ocfs2: Mark inode bad upon validation failure
 during read

On Fri, Oct 31, 2025 at 09:54:41AM -0400, Albin Babu Varghese wrote:
> Hi Heming,
> 
> > I support adding make_bad_inode() in ocfs2_read_inode_block_full().
> > ocfs2_read_locked_inode() calls ocfs2_read_inode_block[_full] to read the inode
> > from disk. However, ocfs2_read_inode_block[_full] have many callers, and in
> > current code, only ocfs2_read_locked_inode() marks the inode as bad. All others
> > forget to set the bad_inode.
> > 
> > The 'forbid' write operations when read-only mode is worth another patch, and
> > I plan to create this patch. This patch adds a similar ext4_emergency_state()
> > function for ocfs2.
> 
> We're working on this as part of the Linux Kernel Mentorship Program, and we'd
> love to take on implementing the read-only check if it's not overly
> complicated. We're just beginners, but we thought it would be a great learning
> experience to work on this following the ext4 pattern you mentioned - if you
> haven't already started working on it by the time you see this reply.

I haven't started the patch job, you are welcome to take it.

- Heming
> 
> > Therefore, your original patch looks good to me. I will provide my Reivewed-by
> > for it.
> 
> Thank you so much for your review and the Reviewed-by tag
> 
> Cheers,
> 	Albin