linux-kernel - Re: [PATCH v4 04/21] arm64/simd: Add scoped guard API for kernel mode SIMD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMj1kXEJbnKuhEjBGxtH6ri9fkJ_AygfLFMXVRbnnVKqWzSrBA@mail.gmail.com>
Date: Fri, 31 Oct 2025 15:05:51 +0100
From: Ard Biesheuvel <ardb@...nel.org>
To: Jonathan Cameron <jonathan.cameron@...wei.com>
Cc: Ard Biesheuvel <ardb+git@...gle.com>, linux-arm-kernel@...ts.infradead.org, 
	linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org, 
	herbert@...dor.apana.org.au, ebiggers@...nel.org, Kees Cook <kees@...nel.org>
Subject: Re: [PATCH v4 04/21] arm64/simd: Add scoped guard API for kernel mode SIMD

On Fri, 31 Oct 2025 at 14:55, Jonathan Cameron
<jonathan.cameron@...wei.com> wrote:
>
> On Fri, 31 Oct 2025 11:39:03 +0100
> Ard Biesheuvel <ardb+git@...gle.com> wrote:
>
> > From: Ard Biesheuvel <ardb@...nel.org>
> >
> > Encapsulate kernel_neon_begin() and kernel_neon_end() using a 'ksimd'
> > cleanup guard. This hides the prototype of those functions, allowing
> > them to be changed for arm64 but not ARM, without breaking code that is
> > shared between those architectures (RAID6, AEGIS-128)
> >
> > It probably makes sense to expose this API more widely across
> > architectures, as it affords more flexibility to the arch code to
> > plumb it in, while imposing more rigid rules regarding the start/end
> > bookends appearing in matched pairs.
> >
> > Reviewed-by: Kees Cook <kees@...nel.org>
> > Reviewed-by: Eric Biggers <ebiggers@...nel.org>
> > Signed-off-by: Ard Biesheuvel <ardb@...nel.org>
> Very nice.
>
> FWIW I looked at all the usecases and other than a couple of trivial
> comments on individual patches they look good to me.
>
> Reviewed-by: Jonathan Cameron <jonathan.cameron@...wei.com>
> For patches 4-19
>

Thanks!