linux-kernel - Re: [PATCH v1] drm/edid: add 6 bpc quirk to the Sharp LQ116M1JW10

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=XuWkudYB3OhPZrLJ0jNXFRyV1c6=czqn2RUo2M9CES9Q@mail.gmail.com>
Date: Fri, 31 Oct 2025 07:24:07 -0700
From: Doug Anderson <dianders@...omium.org>
To: Jani Nikula <jani.nikula@...el.com>
Cc: Ajye Huang <ajye_huang@...pal.corp-partner.google.com>, linux-kernel@...r.kernel.org, 
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>, 
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH v1] drm/edid: add 6 bpc quirk to the Sharp LQ116M1JW10

Hi,

On Fri, Oct 31, 2025 at 3:40 AM Jani Nikula <jani.nikula@...el.com> wrote:
>
> On Fri, 31 Oct 2025, Jani Nikula <jani.nikula@...el.com> wrote:
> > On Thu, 30 Oct 2025, Doug Anderson <dianders@...omium.org> wrote:
> >> Hi,
> >>
> >> On Thu, Oct 30, 2025 at 2:44 AM Ajye Huang
> >> <ajye_huang@...pal.corp-partner.google.com> wrote:
> >>>
> >>> The Sharp LQ116M1JW105 reports that it supports 8 bpc modes,
> >>> but it will happen display noise in some videos.
> >>> So, limit it to 6 bpc modes.
> >>>
> >>> Signed-off-by: Ajye Huang <ajye_huang@...pal.corp-partner.google.com>
> >>> ---
> >>>  drivers/gpu/drm/drm_edid.c | 3 +++
> >>>  1 file changed, 3 insertions(+)
> >>>
> >>> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> >>> index e2e85345aa9a..a73d37fe7ea1 100644
> >>> --- a/drivers/gpu/drm/drm_edid.c
> >>> +++ b/drivers/gpu/drm/drm_edid.c
> >>> @@ -250,6 +250,9 @@ static const struct edid_quirk {
> >>>         EDID_QUIRK('S', 'V', 'R', 0x1019, BIT(EDID_QUIRK_NON_DESKTOP)),
> >>>         EDID_QUIRK('A', 'U', 'O', 0x1111, BIT(EDID_QUIRK_NON_DESKTOP)),
> >>>
> >>> +       /* LQ116M1JW10 displays noise when 8 bpc, but display fine as 6 bpc */
> >>> +       EDID_QUIRK('S', 'H', 'P', 0x154c, EDID_QUIRK_FORCE_6BPC),
> >>
> >> Reviewed-by: Douglas Anderson <dianders@...omium.org>
> >
> > FWIW,
> >
> > Acked-by: Jani Nikula <jani.nikula@...el.com>
>
> And as soon as I hit send, I notice the quirk is missing BIT(). It's a
> bit mask, and the enum signifies the bit number.

Crud, that's not good! Sorry for missing that. :( Definitely glad you noticed!

>From off-list communication, it sounds like there is still some
digging going on to see what's really happening with this panel, too.
There is still some sort of mystery...


-Doug