[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <3006a63b5e38f3d3bfd07047fa8e8ed2e9d2a93d.camel@mailbox.org>
Date: Fri, 31 Oct 2025 15:41:38 +0100
From: Philipp Stanner <phasta@...lbox.org>
To: Pierre-Eric Pelloux-Prayer <pierre-eric@...sy.net>, Philipp Stanner
<phasta@...nel.org>, Matthew Brost <matthew.brost@...el.com>, Danilo
Krummrich <dakr@...nel.org>, Christian König
<ckoenig.leichtzumerken@...il.com>, David Airlie <airlied@...il.com>,
Simona Vetter <simona@...ll.ch>, Tvrtko Ursulin <tvrtko.ursulin@...lia.com>
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
linux-media@...r.kernel.org
Subject: Re: [PATCH v3] drm/sched: Add warning for removing hack in
drm_sched_fini()
On Fri, 2025-10-31 at 15:10 +0100, Pierre-Eric Pelloux-Prayer wrote:
> Hi Philipp,
>
> Le 23/10/2025 à 14:34, Philipp Stanner a écrit :
> > The assembled developers agreed at the X.Org Developers Conference 2025
> > that the hack added for amdgpu in drm_sched_fini() shall be removed. It
> > shouldn't be needed by amdgpu anymore.
> >
> > As it's unclear whether all drivers really follow the life time rule of
> > entities having to be torn down before their scheduler, it is reasonable
> > to warn for a while before removing the hack.
> >
> > Add a warning in drm_sched_fini() that fires if an entity is still
> > active.
> >
> > Signed-off-by: Philipp Stanner <phasta@...nel.org>
[…]
>
> The patch is Acked-by: Pierre-Eric Pelloux-Prayer
> <pierre-eric.pelloux-prayer@....com>
Pushed to drm-misc-next, thanks.
For the future: b4 / maintainer-tools wasn't able to automatically
harvest your Acked-by. Would be helpful if you have the A-b on a single
line without line break and without other content in the future
Have a nice weekend,
P.
>
> Thanks.
>
>
> > spin_unlock(&rq->lock);
> > kfree(sched->sched_rq[i]);
> > }
Powered by blists - more mailing lists