linux-kernel - Re: [PATCH 1/2] usb: xhci: Fix a format bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2797d75d-693f-4a99-9465-a340f956cc4f@linux.intel.com>
Date: Fri, 31 Oct 2025 17:00:42 +0200
From: Mathias Nyman <mathias.nyman@...ux.intel.com>
To: Michal Pecio <michal.pecio@...il.com>,
 Mathias Nyman <mathias.nyman@...el.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] usb: xhci: Fix a format bug

On 10/16/25 19:28, Michal Pecio wrote:
> The width of 'addr' depends on kernel configuration and gibberish is
> printed in traces and dynamic debug on some 32 bit systems like ARM:
> 
>    Removing canceled TD starting at 0xf9c96eb0 (dma) in stream 0 URB 54e247b5
>    Set TR Deq ptr 0x205400000000000, cycle 0
> 
>    Successful Set TR Deq Ptr cmd, deq = @f9c96ef0
> 
> Fix it by casting to 64 bits. No effect on unaffected systems.
> Remove the newline which casuses an empty line to appear next.
> 
> Fixes: d1dbfb942c33 ("xhci: introduce a new move_dequeue_past_td() function to replace old code.")
> Cc: stable@...r.kernel.org
> Signed-off-by: Michal Pecio <michal.pecio@...il.com>
> ---
>   drivers/usb/host/xhci-ring.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
> index c7f658d446cd..6d799a5a062d 100644
> --- a/drivers/usb/host/xhci-ring.c
> +++ b/drivers/usb/host/xhci-ring.c
> @@ -776,7 +776,7 @@ static int xhci_move_dequeue_past_td(struct xhci_hcd *xhci,
>   	ep->queued_deq_ptr = new_deq;
>   
>   	xhci_dbg_trace(xhci, trace_xhci_dbg_cancel_urb,
> -		       "Set TR Deq ptr 0x%llx, cycle %u\n", addr, new_cycle);
> +		       "Set TR Deq ptr 0x%llx, cycle %u", (u64) addr, new_cycle);


Why not %pad and &addr instead?

Thanks
Mathias