linux-kernel - Re: [PATCH] cxl/pci: replace use of system_wq with system_percpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251031161656.porcqeplmln3qzl5@offworld>
Date: Fri, 31 Oct 2025 09:16:56 -0700
From: Davidlohr Bueso <dave@...olabs.net>
To: Marco Crivellari <marco.crivellari@...e.com>
Cc: linux-kernel@...r.kernel.org, linux-cxl@...r.kernel.org,
	Tejun Heo <tj@...nel.org>, Lai Jiangshan <jiangshanlai@...il.com>,
	Frederic Weisbecker <frederic@...nel.org>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	Michal Hocko <mhocko@...e.com>,
	Jonathan Cameron <jonathan.cameron@...wei.com>,
	Dave Jiang <dave.jiang@...el.com>,
	Alison Schofield <alison.schofield@...el.com>,
	Vishal Verma <vishal.l.verma@...el.com>,
	Ira Weiny <ira.weiny@...el.com>,
	Dan Williams <dan.j.williams@...el.com>
Subject: Re: [PATCH] cxl/pci: replace use of system_wq with system_percpu_wq

On Thu, 30 Oct 2025, Marco Crivellari wrote:

>Currently if a user enqueue a work item using schedule_delayed_work() the
>used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use
>WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to
>schedule_work() that is using system_wq and queue_work(), that makes use
>again of WORK_CPU_UNBOUND.
>
>This lack of consistency cannot be addressed without refactoring the API.
>
>system_wq should be the per-cpu workqueue, yet in this name nothing makes
>that clear, so replace system_wq with system_percpu_wq.
>
>The old wq (system_wq) will be kept for a few release cycles.
>
>Suggested-by: Tejun Heo <tj@...nel.org>
>Signed-off-by: Marco Crivellari <marco.crivellari@...e.com>

Acked-by: Davidlohr Bueso <dave@...olabs.net>