linux-kernel - Re: [PATCH net] net: spacemit: Remove broken flow control support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dce4340d-a272-4b86-a7fa-71e6286f798b@lunn.ch>
Date: Fri, 31 Oct 2025 17:27:31 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Vivian Wang <wangruikang@...as.ac.cn>
Cc: Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Yixun Lan <dlan@...too.org>,
	Maxime Chevallier <maxime.chevallier@...tlin.com>,
	Troy Mitchell <troy.mitchell@...ux.spacemit.com>,
	Vadim Fedorenko <vadim.fedorenko@...ux.dev>, netdev@...r.kernel.org,
	linux-riscv@...ts.infradead.org, spacemit@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: spacemit: Remove broken flow control support

On Fri, Oct 31, 2025 at 04:21:53PM +0800, Vivian Wang wrote:
> Currently, emac_set_pauseparam() will oops if userspace calls it while
> the interface is not up. The reason is that if the interface is not up,
> phydev may be NULL, but is still accessed in emac_set_fc() and
> emac_set_fc_autoneg().
> 
> Since the existing flow control implementation is somewhat broken in
> general (for example, it doesn't handle autonegotiation properly),
> remove it for now to fix the more urgent oops problem. A better
> implementation will be sent in future patches.

Fixes for net/stable should be minimal. Please fix the opps, by
returning -ENETDOWN and leave the broken implementation in place. You
can then fix it up in net-next, were we allow more invasive changes.

    Andrew

---
pw-bot: cr