linux-kernel - Re: [PATCH v11 4/9] x86/alternatives: Disable LASS when patching kernel code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ef788788-a4d0-4924-ae81-4db078398fe9@intel.com>
Date: Fri, 31 Oct 2025 10:10:52 -0700
From: Dave Hansen <dave.hansen@...el.com>
To: Sohil Mehta <sohil.mehta@...el.com>, x86@...nel.org,
 Dave Hansen <dave.hansen@...ux.intel.com>,
 Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
 Borislav Petkov <bp@...en8.de>
Cc: Jonathan Corbet <corbet@....net>, "H . Peter Anvin" <hpa@...or.com>,
 Andy Lutomirski <luto@...nel.org>, Josh Poimboeuf <jpoimboe@...nel.org>,
 Peter Zijlstra <peterz@...radead.org>, Ard Biesheuvel <ardb@...nel.org>,
 "Kirill A . Shutemov" <kas@...nel.org>, Xin Li <xin@...or.com>,
 David Woodhouse <dwmw@...zon.co.uk>, Sean Christopherson
 <seanjc@...gle.com>, Rick Edgecombe <rick.p.edgecombe@...el.com>,
 Vegard Nossum <vegard.nossum@...cle.com>,
 Andrew Cooper <andrew.cooper3@...rix.com>,
 Randy Dunlap <rdunlap@...radead.org>,
 Geert Uytterhoeven <geert@...ux-m68k.org>, Kees Cook <kees@...nel.org>,
 Tony Luck <tony.luck@...el.com>,
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
 linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-efi@...r.kernel.org
Subject: Re: [PATCH v11 4/9] x86/alternatives: Disable LASS when patching
 kernel code

On 10/29/25 14:03, Sohil Mehta wrote:
> Introduce LASS-specific STAC/CLAC helpers to set the AC bit only on
> platforms that need it. Clarify the usage of the new helpers versus the
> existing stac()/clac() helpers for SMAP.

Reviewed-by: Dave Hansen <dave.hansen@...ux.intel.com>

One review nit: The

-	/* Note: a barrier is implicit in alternative() */

looks a bit funky in the diffstat. It took me a minute to realize that
you'd moved it. I _probably_ would have specifically called out that you
*added* comments for stac()/clac() and moved and existing duplicated
comment there. Adding a whole new comment block deserves calling out
explicitly. It is far beyond the "clarify" that's in the changelog.

But it's just a nit in the end.