linux-kernel - Re: [PATCH v4 00/28] KVM: x86/mmu: TDX post-populate cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <725c68f2607ad2d4f742fd749ea517a98d669384.camel@intel.com>
Date: Fri, 31 Oct 2025 17:28:52 +0000
From: "Edgecombe, Rick P" <rick.p.edgecombe@...el.com>
To: "chenhuacai@...nel.org" <chenhuacai@...nel.org>, "frankja@...ux.ibm.com"
	<frankja@...ux.ibm.com>, "maz@...nel.org" <maz@...nel.org>,
	"borntraeger@...ux.ibm.com" <borntraeger@...ux.ibm.com>, "pjw@...nel.org"
	<pjw@...nel.org>, "aou@...s.berkeley.edu" <aou@...s.berkeley.edu>,
	"kas@...nel.org" <kas@...nel.org>, "seanjc@...gle.com" <seanjc@...gle.com>,
	"maobibo@...ngson.cn" <maobibo@...ngson.cn>, "pbonzini@...hat.com"
	<pbonzini@...hat.com>, "maddy@...ux.ibm.com" <maddy@...ux.ibm.com>,
	"palmer@...belt.com" <palmer@...belt.com>, "imbrenda@...ux.ibm.com"
	<imbrenda@...ux.ibm.com>, "zhaotianrui@...ngson.cn"
	<zhaotianrui@...ngson.cn>, "anup@...infault.org" <anup@...infault.org>,
	"oliver.upton@...ux.dev" <oliver.upton@...ux.dev>
CC: "kvm@...r.kernel.org" <kvm@...r.kernel.org>, "linux-coco@...ts.linux.dev"
	<linux-coco@...ts.linux.dev>, "Huang, Kai" <kai.huang@...el.com>, "Zhao, Yan
 Y" <yan.y.zhao@...el.com>, "michael.roth@....com" <michael.roth@....com>,
	"binbin.wu@...ux.intel.com" <binbin.wu@...ux.intel.com>, "Weiny, Ira"
	<ira.weiny@...el.com>, "loongarch@...ts.linux.dev"
	<loongarch@...ts.linux.dev>, "ackerleytng@...gle.com"
	<ackerleytng@...gle.com>, "kvmarm@...ts.linux.dev" <kvmarm@...ts.linux.dev>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kvm-riscv@...ts.infradead.org" <kvm-riscv@...ts.infradead.org>, "Annapurve,
 Vishal" <vannapurve@...gle.com>, "linuxppc-dev@...ts.ozlabs.org"
	<linuxppc-dev@...ts.ozlabs.org>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-mips@...r.kernel.org"
	<linux-mips@...r.kernel.org>, "linux-riscv@...ts.infradead.org"
	<linux-riscv@...ts.infradead.org>, "x86@...nel.org" <x86@...nel.org>
Subject: Re: [PATCH v4 00/28] KVM: x86/mmu: TDX post-populate cleanups

On Thu, 2025-10-30 at 13:09 -0700, Sean Christopherson wrote:
> v4:
>  - Collect reviews/acks.
>  - Add a lockdep assertion in kvm_tdp_mmu_map_private_pfn(). [Yan]
>  - Wrap kvm_tdp_mmu_map_private_pfn() with CONFIG_KVM_GUEST_MEMFD=y. [test bot]
>  - Improve (or add) comments. [Kai, and probably others]
>  - s/spte/mirror_spte to make it clear what's being passed in
>  - Update set_external_spte() to take @mirror_spte as well. [Yan]
>  - Move the KVM_BUG_ON() on tdh_mr_extend() failure to the end. [Rick]
>  - Take "all" the locks in tdx_vm_ioctl(). [Kai]
>  - WARN if KVM attempts to map SPTEs into an invalid root. [Yan]
>  - Use tdx_flush_vp_on_cpu() instead of tdx_disassociate_vp() when freeing
>    a vCPU in VCPU_TD_STATE_UNINITIALIZED state. [Yan]

Do you want someone to follow up with a v2 of this after the series lands? (with
Binbin's verbiage comments incorporated)

https://lore.kernel.org/kvm/20251028002824.1470939-1-rick.p.edgecombe@intel.com/#t