linux-kernel - Re: [PATCH v5 3/7] dt-bindings: auxdisplay: add Titan Micro Electronics TM16xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7F647662-59AF-467B-8998-E870F114BDAE@gmail.com>
Date: Fri, 31 Oct 2025 13:59:39 -0400
From: Jean-François Lessard <jefflessard3@...il.com>
To: Rob Herring <robh@...nel.org>
CC: Andy Shevchenko <andy@...nel.org>, Geert Uytterhoeven <geert@...ux-m68k.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 linux-kernel@...r.kernel.org, linux-leds@...r.kernel.org,
 devicetree@...r.kernel.org
Subject: Re: [PATCH v5 3/7] dt-bindings: auxdisplay: add Titan Micro Electronics TM16xx

Hi Rob,

Thank you for the review and Reviewed-by tag. I've addressed all your feedback 
except one item that's causing validation issues.

Le 1 octobre 2025 22 h 58 min 38 s HAE, "Jean-François Lessard" <jefflessard3@...il.com> a écrit :
>Le 1 octobre 2025 22 h 44 min 31 s HAE, Rob Herring <robh@...nel.org> a écrit :
>>On Fri, Sep 26, 2025 at 10:19:04AM -0400, Jean-François Lessard wrote:
>>> Add documentation for TM16xx-compatible 7-segment LED display controllers
>>> with keyscan.

...

>>> +
>>> +allOf:
>>> +  - $ref: /schemas/leds/common.yaml#
>>> +    properties:
>>> +      color: false
>>> +      function: false
>>> +      function-enumerator: false
>>> +  - $ref: /schemas/input/input.yaml#
>>> +  - $ref: /schemas/input/matrix-keymap.yaml#
>>> +  # SPI controllers require 3-wire (combined MISO/MOSI line)
>>> +  - if:
>>> +      properties:
>>> +        compatible:
>>> +          contains:
>>> +            enum:
>>> +              - fdhisi,fd620
>>> +              - fdhisi,fd628
>>> +              - princeton,pt6964
>>> +              - titanmec,tm1618
>>> +              - titanmec,tm1620
>>> +              - titanmec,tm1628
>>> +              - titanmec,tm1638
>>> +              - wxicore,aip1618
>>> +              - wxicore,aip1628
>>> +    then:
>>> +      $ref: /schemas/spi/spi-peripheral-props.yaml#
>>> +      properties:
>>> +        spi-3wire: true
>>
>>You can drop properties.
>>
>
>The issue is spi-3wire is defined in the child node of spi/spi-controller.yaml,
>not in spi-peripheral-props.yaml.
>
>Removing properties did not pass dt validation. Am I missing something?
>

You suggested dropping "properties:" in the SPI 3-wire section:

then:
  $ref: /schemas/spi/spi-peripheral-props.yaml#
  spi-3wire: true
  required:
  - spi-3wire

However, this causes dt_binding_check to fail with:

'spi-3wire' is not one of ['$ref', 'additionalItems', ... 'properties', 
'required', 'then', ...]

Unevaluated properties are not allowed ('spi-3wire' was unexpected)

It appears the schema requires "properties:" to recognize spi-3wire as a 
property constraint rather than a schema keyword. Should I keep the properties 
wrapper, or is there a different way to structure this that I'm missing?

>>> +      required:
>>> +        - spi-3wire
>>
>>With those nits fixed,
>>
>>Reviewed-by: Rob Herring (Arm) <robh@...nel.org>
>>

Thanks for clarifying.

Best regards,
Jean-François