linux-kernel - Re: [RFC PATCH] Drivers: hv: Resolve ambiguity in hypervisor version log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251031183203.GD2612078@liuwe-devbox-debian-v2.local>
Date: Fri, 31 Oct 2025 18:32:03 +0000
From: Wei Liu <wei.liu@...nel.org>
To: Nuno Das Neves <nunodasneves@...ux.microsoft.com>
Cc: Stanislav Kinsburskii <skinsburskii@...ux.microsoft.com>,
	kys@...rosoft.com, haiyangz@...rosoft.com, wei.liu@...nel.org,
	decui@...rosoft.com, linux-hyperv@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH] Drivers: hv: Resolve ambiguity in hypervisor version
 log

On Fri, Oct 10, 2025 at 03:49:17PM -0700, Nuno Das Neves wrote:
> On 10/8/2025 3:43 PM, Stanislav Kinsburskii wrote:
> > Update the log message in hv_common_init to explicitly state that the
> > reported version is for the Microsoft Hypervisor, not the host OS.
> > 
> > Previously, this message was accurate for guests running on Windows
> > hosts, where the host and hypervisor versions matched. With support for
> > Linux hosts running the Hyper-V hypervisor, the host OS and hypervisor
> > versions may differ.
> > 
> > This change avoids confusion by making it clear that the version refers to
> > the Microsoft Hypervisor regardless of the host operating system.
> > 
> > Signed-off-by: Stanislav Kinsburskii <skinsburskii@...ux.microsoft.com>
> > ---
> >  drivers/hv/hv_common.c |    4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/hv/hv_common.c b/drivers/hv/hv_common.c
> > index e109a620c83fc..0289ee4ed5ebf 100644
> > --- a/drivers/hv/hv_common.c
> > +++ b/drivers/hv/hv_common.c
> > @@ -315,9 +315,9 @@ int __init hv_common_init(void)
> >  	int i;
> >  	union hv_hypervisor_version_info version;
> >  
> > -	/* Get information about the Hyper-V host version */
> > +	/* Get information about the Microsoft Hypervisor version */
> >  	if (!hv_get_hypervisor_version(&version))
> > -		pr_info("Hyper-V: Host Build %d.%d.%d.%d-%d-%d\n",
> > +		pr_info("Hyper-V: Hypervisor Build %d.%d.%d.%d-%d-%d\n",
> >  			version.major_version, version.minor_version,
> >  			version.build_number, version.service_number,
> >  			version.service_pack, version.service_branch);
> > 
> > 
> 
> Looks like a good idea.
> 
> Reviewed-by: Nuno Das Neves <nunodasneves@...ux.microsoft.com>

Applied to hyperv-next.