linux-kernel - [PATCH] platform/x86: ideapad-laptop: Use str_on

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20251031184435.44819-1-i@rong.moe>
Date: Sat,  1 Nov 2025 02:44:34 +0800
From: Rong Zhang <i@...g.moe>
To: Ike Panhc <ikepanhc@...il.com>,
	Mark Pearson <mpearson-lenovo@...ebb.ca>,
	"Derek J. Clark" <derekjohn.clark@...il.com>,
	Hans de Goede <hansg@...nel.org>,
	Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: Rong Zhang <i@...g.moe>,
	platform-driver-x86@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	kernel test robot <lkp@...el.com>,
	Julia Lawall <julia.lawall@...ia.fr>
Subject: [PATCH] platform/x86: ideapad-laptop: Use str_on_off() helper

Use the str_on_off() helper instead of open-coding the same operation.
This improves code readability.

Reported-by: kernel test robot <lkp@...el.com>
Reported-by: Julia Lawall <julia.lawall@...ia.fr>
Closes: https://lore.kernel.org/r/202510311551.xjWbHTrm-lkp@intel.com/
Suggested-by: "Ilpo Järvinen" <ilpo.jarvinen@...ux.intel.com>
Link: https://lore.kernel.org/r/2bae2ea7-2ef9-0cfa-0c2c-39a7043b2aa5@linux.intel.com/
Signed-off-by: Rong Zhang <i@...g.moe>
---
This patch is based on 'review-ilpo-next' of pdx86/platform-drivers-x86,
hence depends on my previous patch ("platform/x86: ideapad-laptop:
Protect GBMD/SBMC calls with mutex").
---
 drivers/platform/x86/lenovo/ideapad-laptop.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/platform/x86/lenovo/ideapad-laptop.c b/drivers/platform/x86/lenovo/ideapad-laptop.c
index d2bfaa532020..931a72a2a487 100644
--- a/drivers/platform/x86/lenovo/ideapad-laptop.c
+++ b/drivers/platform/x86/lenovo/ideapad-laptop.c
@@ -475,25 +475,25 @@ static int debugfs_status_show(struct seq_file *s, void *data)
 		if (!read_ec_data(priv->adev->handle, VPCCMD_R_BL, &value))
 			seq_printf(s, "Backlight now:  %lu\n", value);
 		if (!read_ec_data(priv->adev->handle, VPCCMD_R_BL_POWER, &value))
-			seq_printf(s, "BL power value: %s (%lu)\n", value ? "on" : "off", value);
+			seq_printf(s, "BL power value: %s (%lu)\n", str_on_off(value), value);
 
 		seq_puts(s, "=====================\n");
 
 		if (!read_ec_data(priv->adev->handle, VPCCMD_R_RF, &value))
-			seq_printf(s, "Radio status: %s (%lu)\n", value ? "on" : "off", value);
+			seq_printf(s, "Radio status: %s (%lu)\n", str_on_off(value), value);
 		if (!read_ec_data(priv->adev->handle, VPCCMD_R_WIFI, &value))
-			seq_printf(s, "Wifi status:  %s (%lu)\n", value ? "on" : "off", value);
+			seq_printf(s, "Wifi status:  %s (%lu)\n", str_on_off(value), value);
 		if (!read_ec_data(priv->adev->handle, VPCCMD_R_BT, &value))
-			seq_printf(s, "BT status:    %s (%lu)\n", value ? "on" : "off", value);
+			seq_printf(s, "BT status:    %s (%lu)\n", str_on_off(value), value);
 		if (!read_ec_data(priv->adev->handle, VPCCMD_R_3G, &value))
-			seq_printf(s, "3G status:    %s (%lu)\n", value ? "on" : "off", value);
+			seq_printf(s, "3G status:    %s (%lu)\n", str_on_off(value), value);
 
 		seq_puts(s, "=====================\n");
 
 		if (!read_ec_data(priv->adev->handle, VPCCMD_R_TOUCHPAD, &value))
-			seq_printf(s, "Touchpad status: %s (%lu)\n", value ? "on" : "off", value);
+			seq_printf(s, "Touchpad status: %s (%lu)\n", str_on_off(value), value);
 		if (!read_ec_data(priv->adev->handle, VPCCMD_R_CAMERA, &value))
-			seq_printf(s, "Camera status:   %s (%lu)\n", value ? "on" : "off", value);
+			seq_printf(s, "Camera status:   %s (%lu)\n", str_on_off(value), value);
 	}
 
 	seq_puts(s, "=====================\n");

base-commit: ba06b928f05bfd2785260819f6b34b658a04a4e6
-- 
2.51.0