linux-kernel - Re: [PATCH v2] tools/perf/tests/make: use IS_64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aQUINHg0w8_BwtG4@google.com>
Date: Fri, 31 Oct 2025 12:04:20 -0700
From: Namhyung Kim <namhyung@...nel.org>
To: pgnmirror <vacacax16@...il.com>
Cc: linux-kernel@...r.kernel.org,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Ian Rogers <irogers@...gle.com>, linux-perf-users@...r.kernel.org,
	zntsproj <vseokaktusah7@...il.com>
Subject: Re: [PATCH v2] tools/perf/tests/make: use IS_64_BIT for generic lib
 dir

On Fri, Oct 31, 2025 at 06:11:14PM +0300, pgnmirror wrote:
> Use the IS_64_BIT flag to set the lib directory generically for all architectures.
> Previously, this logic was hardcoded for x86/x86_64 only.
> 
> Signed-off-by: zntsproj <vseokaktusah7@...il.com>
> ---
>  tools/perf/tests/make | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/perf/tests/make b/tools/perf/tests/make
> index b650ce886..64066e011 100644
> --- a/tools/perf/tests/make
> +++ b/tools/perf/tests/make
> @@ -53,9 +53,8 @@ endif
>  
>  include $(srctree)/tools/scripts/Makefile.arch
>  
> -# FIXME looks like x86 is the only arch running tests ;-)
> -# we need some IS_(32/64) flag to make this generic
> -ifeq ($(ARCH)$(IS_64_BIT), x861)
> +# use IS_64_BIT to select lib/lib64 generically for all architectures
> +ifeq ($(IS_64_BIT), 1)

IIRC last time we checked this, some arch/distro didn't have lib64
directory on 64-bit systems.  Are you sure if it'd work on them or do
you have any real problem with this?

Thanks,
Namhyung


>  lib = lib64
>  else
>  lib = lib
> -- 
> 2.51.2
>