linux-kernel - Re: [PATCH] tools/perf: Fix spelling typo in tools/perf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0cc4d296-dd2f-5a07-59bd-d9cecc73d28c@os.amperecomputing.com>
Date: Fri, 31 Oct 2025 12:17:01 -0700 (PDT)
From: Ilkka Koskinen <ilkka@...amperecomputing.com>
To: Chu Guangqing <chuguangqing@...pur.com>
cc: john.g.garry@...cle.com, will@...nel.org, james.clark@...aro.org, 
    mike.leach@...aro.org, leo.yan@...ux.dev, peterz@...radead.org, 
    mingo@...hat.com, acme@...nel.org, namhyung@...nel.org, 
    mark.rutland@....com, alexander.shishkin@...ux.intel.com, jolsa@...nel.org, 
    irogers@...gle.com, adrian.hunter@...el.com, 
    linux-arm-kernel@...ts.infradead.org, linux-perf-users@...r.kernel.org, 
    linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tools/perf: Fix spelling typo in tools/perf


On Fri, 31 Oct 2025, Chu Guangqing wrote:
> The json file incorrectly used "acceses" instead of "accesses".
>
> Signed-off-by: Chu Guangqing <chuguangqing@...pur.com>

Thanks for the patch! I have just one comment, would you mind changing the 
subject line to match to the patches touching those event json files? 
Something like this

"perf vendor events arm64 AmpereOneX: Fix spelling typo in the metrics 
file"


With that change

Reviewed-by: Ilkka Koskinen <ilkka@...amperecomputing.com>

Cheers, Ilkka


> ---
> .../arch/arm64/ampere/ampereonex/metrics.json    | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/tools/perf/pmu-events/arch/arm64/ampere/ampereonex/metrics.json b/tools/perf/pmu-events/arch/arm64/ampere/ampereonex/metrics.json
> index 6817cac149e0..a29aadc9b2e3 100644
> --- a/tools/perf/pmu-events/arch/arm64/ampere/ampereonex/metrics.json
> +++ b/tools/perf/pmu-events/arch/arm64/ampere/ampereonex/metrics.json
> @@ -388,55 +388,55 @@
>         "MetricExpr": "L1D_CACHE_RW / L1D_CACHE",
>         "BriefDescription": "L1D cache access - demand",
>         "MetricGroup": "Cache",
> -        "ScaleUnit": "100percent of cache acceses"
> +        "ScaleUnit": "100percent of cache accesses"
>     },
>     {
>         "MetricName": "l1d_cache_access_prefetches",
>         "MetricExpr": "L1D_CACHE_PRFM / L1D_CACHE",
>         "BriefDescription": "L1D cache access - prefetch",
>         "MetricGroup": "Cache",
> -        "ScaleUnit": "100percent of cache acceses"
> +        "ScaleUnit": "100percent of cache accesses"
>     },
>     {
>         "MetricName": "l1d_cache_demand_misses",
>         "MetricExpr": "L1D_CACHE_REFILL_RW / L1D_CACHE",
>         "BriefDescription": "L1D cache demand misses",
>         "MetricGroup": "Cache",
> -        "ScaleUnit": "100percent of cache acceses"
> +        "ScaleUnit": "100percent of cache accesses"
>     },
>     {
>         "MetricName": "l1d_cache_demand_misses_read",
>         "MetricExpr": "L1D_CACHE_REFILL_RD / L1D_CACHE",
>         "BriefDescription": "L1D cache demand misses - read",
>         "MetricGroup": "Cache",
> -        "ScaleUnit": "100percent of cache acceses"
> +        "ScaleUnit": "100percent of cache accesses"
>     },
>     {
>         "MetricName": "l1d_cache_demand_misses_write",
>         "MetricExpr": "L1D_CACHE_REFILL_WR / L1D_CACHE",
>         "BriefDescription": "L1D cache demand misses - write",
>         "MetricGroup": "Cache",
> -        "ScaleUnit": "100percent of cache acceses"
> +        "ScaleUnit": "100percent of cache accesses"
>     },
>     {
>         "MetricName": "l1d_cache_prefetch_misses",
>         "MetricExpr": "L1D_CACHE_REFILL_PRFM / L1D_CACHE",
>         "BriefDescription": "L1D cache prefetch misses",
>         "MetricGroup": "Cache",
> -        "ScaleUnit": "100percent of cache acceses"
> +        "ScaleUnit": "100percent of cache accesses"
>     },
>     {
>         "MetricName": "ase_scalar_mix",
>         "MetricExpr": "ASE_SCALAR_SPEC / OP_SPEC",
>         "BriefDescription": "Proportion of advanced SIMD data processing operations (excluding DP_SPEC/LD_SPEC) scalar operations",
>         "MetricGroup": "Instructions",
> -        "ScaleUnit": "100percent of cache acceses"
> +        "ScaleUnit": "100percent of cache accesses"
>     },
>     {
>         "MetricName": "ase_vector_mix",
>         "MetricExpr": "ASE_VECTOR_SPEC / OP_SPEC",
>         "BriefDescription": "Proportion of advanced SIMD data processing operations (excluding DP_SPEC/LD_SPEC) vector operations",
>         "MetricGroup": "Instructions",
> -        "ScaleUnit": "100percent of cache acceses"
> +        "ScaleUnit": "100percent of cache accesses"
>     }
> ]
> -- 
> 2.43.7
>
>
>