linux-kernel - Re: [PATCH v22 03/28] riscv: zicfiss / zicfilp enumeration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9230fa65-6b8e-ebf6-f215-b3a3bb7357d9@kernel.org>
Date: Fri, 31 Oct 2025 13:22:23 -0600 (MDT)
From: Paul Walmsley <pjw@...nel.org>
To: Deepak Gupta <debug@...osinc.com>
cc: Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, 
    Borislav Petkov <bp@...en8.de>, Dave Hansen <dave.hansen@...ux.intel.com>, 
    x86@...nel.org, "H. Peter Anvin" <hpa@...or.com>, 
    Andrew Morton <akpm@...ux-foundation.org>, 
    "Liam R. Howlett" <Liam.Howlett@...cle.com>, 
    Vlastimil Babka <vbabka@...e.cz>, 
    Lorenzo Stoakes <lorenzo.stoakes@...cle.com>, 
    Paul Walmsley <paul.walmsley@...ive.com>, 
    Palmer Dabbelt <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>, 
    Conor Dooley <conor@...nel.org>, Rob Herring <robh@...nel.org>, 
    Krzysztof Kozlowski <krzk+dt@...nel.org>, Arnd Bergmann <arnd@...db.de>, 
    Christian Brauner <brauner@...nel.org>, 
    Peter Zijlstra <peterz@...radead.org>, Oleg Nesterov <oleg@...hat.com>, 
    Eric Biederman <ebiederm@...ssion.com>, Kees Cook <kees@...nel.org>, 
    Jonathan Corbet <corbet@....net>, Shuah Khan <shuah@...nel.org>, 
    Jann Horn <jannh@...gle.com>, Conor Dooley <conor+dt@...nel.org>, 
    Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
    Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
    Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
    Andreas Hindborg <a.hindborg@...nel.org>, 
    Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, 
    Benno Lossin <lossin@...nel.org>, linux-kernel@...r.kernel.org, 
    linux-fsdevel@...r.kernel.org, linux-mm@...ck.org, 
    linux-riscv@...ts.infradead.org, devicetree@...r.kernel.org, 
    linux-arch@...r.kernel.org, linux-doc@...r.kernel.org, 
    linux-kselftest@...r.kernel.org, alistair.francis@....com, 
    richard.henderson@...aro.org, jim.shu@...ive.com, andybnac@...il.com, 
    kito.cheng@...ive.com, charlie@...osinc.com, atishp@...osinc.com, 
    evan@...osinc.com, cleger@...osinc.com, alexghiti@...osinc.com, 
    samitolvanen@...gle.com, broonie@...nel.org, rick.p.edgecombe@...el.com, 
    rust-for-linux@...r.kernel.org, Zong Li <zong.li@...ive.com>
Subject: Re: [PATCH v22 03/28] riscv: zicfiss / zicfilp enumeration

On Thu, 23 Oct 2025, Deepak Gupta wrote:

> This patch adds support for detecting zicfiss and zicfilp. zicfiss and
> zicfilp stands for unprivleged integer spec extension for shadow stack
> and branch tracking on indirect branches, respectively.
> 
> This patch looks for zicfiss and zicfilp in device tree and accordinlgy
> lights up bit in cpu feature bitmap. Furthermore this patch adds detection
> utility functions to return whether shadow stack or landing pads are
> supported by cpu.
> 
> Reviewed-by: Zong Li <zong.li@...ive.com>
> Reviewed-by: Alexandre Ghiti <alexghiti@...osinc.com>
> Signed-off-by: Deepak Gupta <debug@...osinc.com>

This patch introduces some 'checkpatch.pl --strict' messages:

CHECK: Alignment should match open parenthesis
#68: FILE: arch/riscv/kernel/cpufeature.c:278:
+static int riscv_cfilp_validate(const struct riscv_isa_ext_data *data,
+			      const unsigned long *isa_bitmap)

CHECK: Alignment should match open parenthesis
#77: FILE: arch/riscv/kernel/cpufeature.c:287:
+static int riscv_cfiss_validate(const struct riscv_isa_ext_data *data,
+			      const unsigned long *isa_bitmap)


I'll fix them up here in the event that v22 goes in, but please do the 
same on your side in case a new version is needed.  


thanks,

- Paul